Bug 290907 - sysutils/appjail{,-devel}: depend on pkg
Summary: sysutils/appjail{,-devel}: depend on pkg
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jesús Daniel Colmenares Oviedo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-09 04:08 UTC by Paavo-Einari Kaipila
Modified: 2025-11-09 19:09 UTC (History)
0 users

See Also:
dtxdf: maintainer-feedback+


Attachments
0001-sysutils-appjail-depend-on-pkg.patch (692 bytes, patch)
2025-11-09 04:10 UTC, Paavo-Einari Kaipila
no flags Details | Diff
0001-sysutils-appjaili-devel-depend-on-pkg.patch (689 bytes, patch)
2025-11-09 04:10 UTC, Paavo-Einari Kaipila
no flags Details | Diff
0001-sysutils-appjail-add-pkg-as-a-dependency.patch (1.30 KB, patch)
2025-11-09 07:20 UTC, Paavo-Einari Kaipila
no flags Details | Diff
0001-sysutils-appjail-devel-add-pkg-as-a-dependency.patch (1.46 KB, patch)
2025-11-09 07:21 UTC, Paavo-Einari Kaipila
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paavo-Einari Kaipila 2025-11-09 04:08:10 UTC
Probably only affects very few people with unusual setups, but I encountered this

root@tarbsd-homelab:/ # appjail fetch pkgbase
[00:00:00] [ error ] pkg(8) is not present on the host. Cannot continue ...
root@tarbsd-homelab:/ #

Portlint doesn't understand that ${PKG_ORIGIN} there and it triggers a false positive.
Comment 1 Paavo-Einari Kaipila 2025-11-09 04:10:13 UTC
Created attachment 265279 [details]
0001-sysutils-appjail-depend-on-pkg.patch
Comment 2 Paavo-Einari Kaipila 2025-11-09 04:10:39 UTC
Created attachment 265280 [details]
0001-sysutils-appjaili-devel-depend-on-pkg.patch
Comment 3 Jesús Daniel Colmenares Oviedo freebsd_committer freebsd_triage 2025-11-09 06:08:06 UTC
Hi,

Thanks for reporting this.

I'll add pkg as an optional dependency, but enabled by default. See for example the other dependencies, such as debootstrap or doas.
Comment 4 Paavo-Einari Kaipila 2025-11-09 07:20:49 UTC
Created attachment 265283 [details]
0001-sysutils-appjail-add-pkg-as-a-dependency.patch
Comment 5 Paavo-Einari Kaipila 2025-11-09 07:21:38 UTC
Created attachment 265284 [details]
0001-sysutils-appjail-devel-add-pkg-as-a-dependency.patch
Comment 6 Paavo-Einari Kaipila 2025-11-09 07:26:54 UTC
Interesting, portlint doesn't get offended if pkg is an optional dependency.

And thanks for this app. I've been thinking about replacing iocage for several years. Finding this finally triggered me to do that.
Comment 7 Jesús Daniel Colmenares Oviedo freebsd_committer freebsd_triage 2025-11-09 18:29:05 UTC
> And thanks for this app. I've been thinking about replacing iocage for several years. Finding this finally triggered me to do that.

And thanks for that! Be welcome!
Comment 8 commit-hook freebsd_committer freebsd_triage 2025-11-09 19:08:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cbbef72ee0a593611661f89ee30963eb95efbbb0

commit cbbef72ee0a593611661f89ee30963eb95efbbb0
Author:     Jesús Daniel Colmenares Oviedo <dtxdf@FreeBSD.org>
AuthorDate: 2025-11-09 18:45:41 +0000
Commit:     Jesús Daniel Colmenares Oviedo <dtxdf@FreeBSD.org>
CommitDate: 2025-11-09 19:06:28 +0000

    sysutils/appjail{,-devel}: Add PKG option

    AppJail optionally depends on ${PKG_ORIGIN} to create a base directory
    using pkgbase. We enable the PKG option by default, as it will become
    the preferred method.

    PR:             290907
    Reported by:    pkaipila@gmail.com

 sysutils/appjail-devel/Makefile | 12 ++++++++----
 sysutils/appjail/Makefile       |  6 +++++-
 2 files changed, 13 insertions(+), 5 deletions(-)
Comment 9 Jesús Daniel Colmenares Oviedo freebsd_committer freebsd_triage 2025-11-09 19:09:35 UTC
Committed, thanks!