Bug 290921 - converters/py-svglib: update to 1.6.0
Summary: converters/py-svglib: update to 1.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL: https://github.com/deeplook/svglib/bl...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-09 20:48 UTC by Paavo-Einari Kaipila
Modified: 2025-11-23 10:12 UTC (History)
0 users

See Also:
kai: maintainer-feedback+


Attachments
0001-converters-py-svglib-update-to-1.6.0.patch (2.04 KB, patch)
2025-11-09 20:49 UTC, Paavo-Einari Kaipila
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paavo-Einari Kaipila 2025-11-09 20:48:54 UTC

    
Comment 1 Paavo-Einari Kaipila 2025-11-09 20:49:56 UTC
Created attachment 265302 [details]
0001-converters-py-svglib-update-to-1.6.0.patch
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2025-11-13 07:18:47 UTC
Hi,

thanks for the patch! I took a quick look at it and noticed three things:

- When the test suite (via "make test") is run, one test fails because the "rlPyCairo" package (not in the ports tree, yet) is missing, which seems to act as a plugin for py-reportlab.

- "rlPyCairo" is also listed in "pyproject.toml". Is there a specific reason why this was omitted from the port's Makefile?

- Incidentally, the remaining dependencies should also be updated in the Makefile, as indicated in "pyproject.toml" to be in sync.
Comment 3 Paavo-Einari Kaipila 2025-11-14 09:51:45 UTC
Pure oversights. Turns out that poudriere testport doesn't test very much with interpreted languages.

I can take another attempt during the weekend or leave it to you. That rlPyCairo is needed, so what to do with that? Will you maintain it? I likely won't because my use of it is only indirect and even that indirect use is quite rare.
Comment 4 Kai Knoblich freebsd_committer freebsd_triage 2025-11-20 06:11:44 UTC
(In reply to Paavo-Einari Kaipila from comment #3)

Thank you for your input. I also understand your point about the indirect use of the port in connection with maintaining it.

It seems that quite a few people feel the same way in regard to "py-cairo", see upstream issue #421 at "See also". Some projects already pinned py-svglib to version 1.5.1 until the problem is solved.

I'll take a closer look at it in the next few days. If you've already worked out a patch for the "rlPyCairo" dependency, feel free to attach it here.
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-11-23 10:02:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=64bd2920de22b481311098ffed175f60e42d773c

commit 64bd2920de22b481311098ffed175f60e42d773c
Author:     Kai Knoblich <kai@FreeBSD.org>
AuthorDate: 2025-11-23 10:01:14 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2025-11-23 10:01:14 +0000

    graphics/py-rlpycairo: New port

    This is a plugin for the ReportLab PDF Toolkit, which constructs rich
    PDF documents, and is also used for the creation of charts in a variety
    of bitmap and vector formats.

    This plugin is intended to replace most of the usage of the libart based
    C extension _renderPM which has been shown to have issues when rendering
    complex documents.

    PR:             290921

 graphics/Makefile                                  |  1 +
 graphics/py-rlpycairo/Makefile (new)               | 24 ++++++++++++++++++++++
 graphics/py-rlpycairo/distinfo (new)               |  3 +++
 .../py-rlpycairo/files/patch-pyproject.toml (new)  | 13 ++++++++++++
 graphics/py-rlpycairo/pkg-descr (new)              |  7 +++++++
 5 files changed, 48 insertions(+)
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-11-23 10:02:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=05f14b30ef5d73c43f0e6eb8c5b53a4814d4cbf2

commit 05f14b30ef5d73c43f0e6eb8c5b53a4814d4cbf2
Author:     Paavo-Einari Kaipila <pkaipila@gmail.com>
AuthorDate: 2025-11-23 10:01:14 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2025-11-23 10:01:14 +0000

    converters/py-svglib: Update to 1.6.0

    * Switch to the PEP517 build framework.

    Changelog:

    https://github.com/deeplook/svglib/blob/v1.6.0/CHANGELOG.rst

    PR:             290921
    Co-authored-by: Kai Knoblich <kai@FreeBSD.org>

 converters/py-svglib/Makefile | 12 +++++++-----
 converters/py-svglib/distinfo |  6 +++---
 2 files changed, 10 insertions(+), 8 deletions(-)
Comment 7 Kai Knoblich freebsd_committer freebsd_triage 2025-11-23 10:12:40 UTC
(In reply to Paavo-Einari Kaipila from comment #1)

Committed with some adaptions along with the new dependency graphics/py-rlpycairo, thanks!