Created attachment 265315 [details] Patch for openfec * Use variables (DISTVERSIONPREFIX and DISTVERSION) as instructed by Porters Handbook [1] * Remove incorrect depdenencies * Remove USES= tar:tgz (unnecessary and incorrect GitHub uses tar.gz) * Add USES= pathfix to fix install location for .pc file and keep build log consistent * Respect (C)FLAGS and framework overall [2] * Add "make test" target 1: https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github (see example 14) 2: https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags
Compile and runtime tested on FreeBSD 14.3-RELEASE (amd64) (make, make check-plist, make test) Poudriere testport OK 13.5-RELEASE (amd64) Poudriere testport OK 13.5-RELEASE (i386) Poudriere testport OK 14.3-RELEASE (amd64) Please test ports at least with DEVELOPER=yes enabled to catch (in many cases) incorrect dependency definitions. Poudriere testport is also very useful and bulk -t
Thanks! Sorry about that tar:tgz thing, that was because I started porting the original software not the fork that they specifically released as a .tgz and I forgot to remove this. The original upstream also had a really broken cmake setup -- it didn't even have an install target. Upstream has been trying to get this software working on FreeBSD, so they will really appreciate this.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=181fe3f6dcf173e152c32a5f88c18725104cd13e commit 181fe3f6dcf173e152c32a5f88c18725104cd13e Author: Mark Felder <feld@FreeBSD.org> AuthorDate: 2025-11-11 20:06:55 +0000 Commit: Mark Felder <feld@FreeBSD.org> CommitDate: 2025-11-11 20:08:11 +0000 devel/openfec: Port improvements PR: 290936 devel/openfec/Makefile | 17 ++++---- devel/openfec/files/patch-CMakeLists.txt (new) | 55 ++++++++++++++++++++++++++ 2 files changed, 64 insertions(+), 8 deletions(-)