Bug 290948 - dns/dsc: use libpcap from base, before using port.
Summary: dns/dsc: use libpcap from base, before using port.
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-11 10:57 UTC by Leo Vandewoestijne
Modified: 2025-12-04 23:11 UTC (History)
1 user (show)

See Also:


Attachments
dsc (448 bytes, patch)
2025-11-11 10:57 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Vandewoestijne 2025-11-11 10:57:02 UTC
Created attachment 265328 [details]
dsc

This port was still not adjusted after warnings in PR 262976.
Enlosed patch does.
Succesfully tested in Poudriere.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2025-11-12 15:03:44 UTC
Does it really need a libpcap from ports?
Comment 2 Leo Vandewoestijne 2025-12-02 09:43:22 UTC
(In reply to Vladimir Druzenko from comment #1)

I think the answer to your question is yes.

In Poudriere I don't seem to have libpcap from system at all, so I can imagine there are others jails without it also. So then you really would need it, yes.

Opposite, I've actually nowhere had the chanche to see how libpcap from system does. Which I would prefer, when possible.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2025-12-04 23:04:40 UTC
> In Poudriere I don't seem to have libpcap from system at all,
> so I can imagine there are others jails without it also.
How did you achieve this? :-D

In my opinion, it is always better to use libraries from the base, except in situations where there are good reasons to use them from ports (for example, a version that is too old).
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2025-12-04 23:11:01 UTC
Try this patch:

--- a/dns/dsc/Makefile
+++ b/dns/dsc/Makefile
@@ -12,8 +12,7 @@ LICENSE=      BSD3CLAUSE

 BUILD_DEPENDS= ${RUN_DEPENDS}
 LIB_DEPENDS=   libmaxminddb.so:net/libmaxminddb
-RUN_DEPENDS=   libpcap>=1.8.1:net/libpcap \
-               p5-Proc-PID-File>=1.28:devel/p5-Proc-PID-File \
+RUN_DEPENDS=   p5-Proc-PID-File>=1.28:devel/p5-Proc-PID-File \
                p5-XML-Simple>=2.24:textproc/p5-XML-Simple

 USES=          gmake localbase perl5 pkgconfig python shebangfix
@@ -23,6 +22,8 @@ SHEBANG_FILES=        src/dsc-psl-convert
 GNU_CONFIGURE= yes
 CONFIGURE_ARGS=        --with-pid-file=/var/run/${PORTNAME}.pid

+LDFLAGS+=      -L/usr/lib
+
 SUB_FILES=     pkg-message

 OPTIONS_DEFINE=        DOCS