sftp-server needs to check whether localtime() has failed and must not pass a NULL pointer to strftime() - this would lead to a segfault crash. cd freebsd-src/crypto/openssh git grep -B 1 -n localtime sftp-server.c sftp-server.c-1015- strftime(buf, sizeof(buf), "%Y%m%d-%H:%M:%S", sftp-server.c:1016: localtime(&t)); -- sftp-server.c-1072- strftime(buf, sizeof(buf), "%Y%m%d-%H:%M:%S", sftp-server.c:1073: localtime(&t)); -- sftp-server.c-1495- strftime(buf, sizeof(buf), "%Y%m%d-%H:%M:%S", sftp-server.c:1496: localtime(&t));
Can you submit this one upstream as well? Also curious about the discovery -- do you have a case that fails, or is this just by inspection?