Bug 291013 - x11-fm/filerunner: Take maintainership
Summary: x11-fm/filerunner: Take maintainership
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://sourceforge.net/projects/file...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-14 14:23 UTC by mew14930xvi
Modified: 2025-11-17 23:00 UTC (History)
1 user (show)

See Also:

Attachments
Update to 24.07.12.20 (15.91 KB, patch)
2025-11-14 14:23 UTC, mew14930xvi 		no flags Details | Diff
Take maintainership (18.24 KB, patch)
2025-11-17 12:30 UTC, mew14930xvi 		no flags Details | Diff
Take maintainership (18.25 KB, patch)
2025-11-17 23:00 UTC, mew14930xvi 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mew14930xvi 2025-11-14 14:23:03 UTC 
Created attachment 265412 [details]
Update to 24.07.12.20

Update LICENSE.
Remove USE_LDCONFIG.
Switch from REINPLACE_CMD to USES=shebangfix.
Add NO_ARCH=yes.
Use PORTDATA.
Use INSTALL_SCRIPT and remove CHMOD.
Install .desktop file and icons.
Switch symbolic link from absolute path to relative path.
Update pkg-descr.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2025-11-14 17:16:00 UTC 
Update patch after last commit.
Comment 2 mew14930xvi 2025-11-14 18:45:05 UTC 
The port was changed after the report.
Comment 3 mew14930xvi 2025-11-17 12:30:20 UTC 
Created attachment 265469 [details]
Take maintainership

By the way, I know that parentheses are mentioned in make(1) when using cd, but it is often not used in port Makefiles.
Some say it's not necessary.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290515#c2
The example in 6.16.3 of the porter's handbook also has no parentheses.
Comment 4 mew14930xvi 2025-11-17 12:33:21 UTC 
Update patch.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2025-11-17 19:09:48 UTC 
Check please this:
_ELF=           extrafont.so libinotify1.4.1.so libpanicTrap1.0.0.so panicTrap.o
_ICONS=         16 32 48 128 256

do-install:
        (cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${DATADIR} \
                '! ( -name fr -o -name frftp ${_ELF:S|^|-o -name |} ) ')
        (cd ${WRKSRC} && ${INSTALL_SCRIPT} fr frftp ${STAGEDIR}${DATADIR})
        ${INSTALL_DATA} ${WRKSRC}/Makefiles/${PORTNAME}.desktop \
                ${STAGEDIR}${DESKTOPDIR}
        ${MKDIR} ${_ICONS:C|([0-9]+)|${STAGEDIR}${PREFIX}/share/icons/hicolor/\1x\1/apps|}
.for size in ${_ICONS}
        ${INSTALL_DATA} ${WRKSRC}/icons/${PORTNAME}-${size}x${size}.png \
                ${STAGEDIR}${PREFIX}/share/icons/hicolor/${size}x${size}/apps/${PORTNAME}.png
.endfor
        ${RLN} ${STAGEDIR}${DATADIR}/fr ${STAGEDIR}${PREFIX}/bin

1. Use DESKTOPDIR variable from Mk/bsd.port.mk.
2. Use 1 MKDIR for all dirs.
3. Unnecessary "@${MKDIR} ${STAGEDIR}${DATADIR}" - COPYTREE_SHARE create it self.
4. Use "." instead of "\*" in COPYTREE_SHARE.
5. Shorter condition in COPYTREE_SHARE.
6. Use "|" instead of "/" in ${_ELF:S * }.
Comment 6 mew14930xvi 2025-11-17 23:00:05 UTC 
Created attachment 265478 [details]
Take maintainership