Bug 291023 - emulators/virtualbox-ose-7x: make Qt optional for building
Summary: emulators/virtualbox-ose-7x: make Qt optional for building
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-15 05:13 UTC by takahiro.kurosawa
Modified: 2025-11-21 19:45 UTC (History)
1 user (show)

See Also:
vvd: maintainer-feedback+
vvd: merge-quarterly+

Attachments
patch that makes Qt optional for building (3.39 KB, patch)
2025-11-15 05:13 UTC, takahiro.kurosawa 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description takahiro.kurosawa 2025-11-15 05:13:54 UTC 
Created attachment 265419 [details]
patch that makes Qt optional for building

The attached patch removes build dependency for Qt when NLS or graphical
frontend is not required. This may save disk space for portmaster users
and build time espacially for OPTIONS_UNSET="X11 NLS" users.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2025-11-21 17:10:51 UTC 
1. Remove USE_QT.

2. Use goal instead of ".if":
post-patch-NLS-off:
        @${ECHO} 'VBOX_WITH_NLS =' >> ${WRKSRC}/LocalConfig.kmk
        @${ECHO} 'VBOX_WITH_MAIN_NLS =' >> ${WRKSRC}/LocalConfig.kmk
        @${ECHO} 'VBOX_WITH_PUEL_NLS =' >> ${WRKSRC}/LocalConfig.kmk
        @${ECHO} 'VBOX_WITH_VBOXMANAGE_NLS =' >> ${WRKSRC}/LocalConfig.kmk

Testing in progress…
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-11-21 19:02:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4f1b651ebc7aa3fca1b19f4f45fed00e5a397d57

commit 4f1b651ebc7aa3fca1b19f4f45fed00e5a397d57
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-11-21 18:49:00 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-11-21 18:58:54 +0000

    emulators/virtualbox-ose-{,-nox11}-7{0,1,2}: Make Qt optional for building

    Remove build dependency for Qt when NLS and graphical frontend is not
    required.

    PR:             291023
    Co-authored-by: takahiro.kurosawa@gmail.com
    MFH:            2025Q4

 emulators/virtualbox-ose-70/Makefile | 11 ++++++++---
 emulators/virtualbox-ose-71/Makefile | 11 ++++++++---
 emulators/virtualbox-ose-72/Makefile | 12 +++++++++---
 3 files changed, 25 insertions(+), 9 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2025-11-21 19:03:33 UTC 
A commit in branch 2025Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ff235af03459d4bac2415b7c736f725d608317de

commit ff235af03459d4bac2415b7c736f725d608317de
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-11-21 18:49:00 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-11-21 19:03:17 +0000

    emulators/virtualbox-ose-{,-nox11}-7{0,1,2}: Make Qt optional for building

    Remove build dependency for Qt when NLS and graphical frontend is not
    required.

    PR:             291023
    Co-authored-by: takahiro.kurosawa@gmail.com
    MFH:            2025Q4
    (cherry picked from commit 4f1b651ebc7aa3fca1b19f4f45fed00e5a397d57)

 emulators/virtualbox-ose-70/Makefile | 11 ++++++++---
 emulators/virtualbox-ose-71/Makefile | 11 ++++++++---
 emulators/virtualbox-ose-72/Makefile | 12 +++++++++---
 3 files changed, 25 insertions(+), 9 deletions(-)
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2025-11-21 19:45:23 UTC 
Thanks.