Bug 291038 - devel/agar: Update to 1.7.1
Summary: devel/agar: Update to 1.7.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://github.com/JulNadeauCA/libaga...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-16 03:31 UTC by Julien Nadeau
Modified: 2025-11-17 10:52 UTC (History)
1 user (show)

See Also:


Attachments
Patch for agar 1.7.1 (8.52 KB, patch)
2025-11-16 03:31 UTC, Julien Nadeau
no flags Details | Diff
Revised patch for agar 1.7.1 (11.32 KB, patch)
2025-11-17 02:53 UTC, Julien Nadeau
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Nadeau 2025-11-16 03:31:59 UTC
Created attachment 265447 [details]
Patch for agar 1.7.1

devel/agar: Update to 1.7.1

ChangeLog: https://www.patreon.com/posts/agar-1-7-1-is-143623905
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2025-11-16 18:30:40 UTC
Suggestion:
1. Replace PORTVERSION with DISTVERSION.
2. Remove GNU_CONFIGURE_MANPREFIX=${PREFIX}/share.
3. Move SDL options in RADIO instead of *_PREVENTS.
4. Fix warnings from portclippy.

--- a/devel/agar/Makefile
+++ b/devel/agar/Makefile
@@ -1,6 +1,5 @@
 PORTNAME=      agar
-PORTVERSION=   1.7.0
-PORTREVISION=  2
+DISTVERSION=   1.7.1
 CATEGORIES=    devel
 MASTER_SITES=  http://stable.hypertriton.com/agar/

@@ -13,22 +12,15 @@ LICENSE_COMB=               multi
 LICENSE_FILE_BSD2CLAUSE=${WRKSRC}/LICENSE
 LICENSE_FILE_OFL11=    ${WRKSRC}/OFL.txt

+LIB_DEPENDS=   libpng.so:graphics/png \
+               libfreetype.so:print/freetype2
+
 USES=          libtool localbase pathfix perl5 pkgconfig jpeg gl
-USE_PERL5=     build
+USE_GL=                gl glu
 USE_LDCONFIG=  yes
+USE_PERL5=     build

 GNU_CONFIGURE= yes
-GNU_CONFIGURE_MANPREFIX=${PREFIX}/share
-
-OPTIONS_DEFINE=        DEBUG FONTCONFIG PORTAUDIO SDL SDL2 SNDFILE THREADS X11 XINERAMA
-OPTIONS_DEFAULT=FONTCONFIG SDL2 THREADS X11 XINERAMA
-OPTIONS_SUB=   yes
-
-SDL_DESC=      SDL 1.2 support in Agar GUI library
-SDL2_DESC=     SDL 2.0 support in Agar GUI library
-PORTAUDIO_DESC=        Portaudio support in Agar AU library
-SNDFILE_DESC=  Audio file support in Agar AU library
-
 CONFIGURE_ARGS+=--with-jpeg=${LOCALBASE} \
                --with-png=${LOCALBASE} \
                --with-freetype=${LOCALBASE} \
@@ -38,12 +30,6 @@ CONFIGURE_ARGS+=--with-jpeg=${LOCALBASE} \
                --enable-sg \
                --enable-map \
                --enable-network
-
-USE_GL=                gl glu
-
-LIB_DEPENDS=   libpng.so:graphics/png \
-               libfreetype.so:print/freetype2
-
 .if defined(MACHINE_CPU) && (${MACHINE_CPU:Msse} == "sse" || ${MACHINE_CPU:Mamd64} == "amd64")
 CONFIGURE_ARGS+=--with-sse \
                --with-sse-inline
@@ -51,29 +37,38 @@ CONFIGURE_ARGS+=--with-sse \
 CONFIGURE_ARGS+=--without-sse
 .endif

-DEBUG_CONFIGURE_ENABLE= debug
+OPTIONS_DEFINE=        DEBUG FONTCONFIG PORTAUDIO SNDFILE THREADS X11 XINERAMA
+OPTIONS_DEFAULT=FONTCONFIG SDL2 THREADS X11 XINERAMA
+OPTIONS_RADIO= SDL
+OPTIONS_RADIO_SDL=     SDL1 SDL2
+OPTIONS_SUB=   yes
+
+PORTAUDIO_DESC=        Portaudio support in Agar AU library
+SDL1_DESC=     SDL 1.2 support in Agar GUI library
+SDL2_DESC=     SDL 2.0 support in Agar GUI library
+SNDFILE_DESC=  Audio file support in Agar AU library
+
+DEBUG_CONFIGURE_ENABLE=        debug

-FONTCONFIG_CONFIGURE_WITH=fontconfig
 FONTCONFIG_LIB_DEPENDS=        libfontconfig.so:x11-fonts/fontconfig
+FONTCONFIG_CONFIGURE_WITH=fontconfig

-PORTAUDIO_CONFIGURE_WITH=portaudio
-PORTAUDIO_LIB_DEPENDS= libportaudio.so:audio/portaudio
 PORTAUDIO_IMPLIES=     THREADS
+PORTAUDIO_LIB_DEPENDS= libportaudio.so:audio/portaudio
+PORTAUDIO_CONFIGURE_WITH=portaudio

-SDL_USES=              sdl
-SDL_USE=               SDL=sdl
-SDL_CONFIGURE_WITH=    sdl
-SDL_PREVENTS=          SDL2
+SDL1_USES=             sdl
+SDL1_USE=              SDL=sdl
+SDL1_CONFIGURE_WITH=   sdl

 SDL2_USES=             sdl
 SDL2_USE=              SDL=sdl2
 SDL2_CONFIGURE_WITH=   sdl2
-SDL2_PREVENTS=         SDL

+SNDFILE_IMPLIES=       THREADS
+SNDFILE_LIB_DEPENDS=   libsndfile.so:audio/libsndfile
 SNDFILE_CONFIGURE_ON=  --with-sndfile=${LOCALBASE}
 SNDFILE_CONFIGURE_OFF= --without-sndfile
-SNDFILE_LIB_DEPENDS=   libsndfile.so:audio/libsndfile
-SNDFILE_IMPLIES=       THREADS

 THREADS_CONFIGURE_ENABLE=threads

@@ -82,11 +77,11 @@ X11_USE=            XORG=x11,xext
 X11_CONFIGURE_ON=      --with-x=${LOCALBASE} --with-glx
 X11_CONFIGURE_OFF=     --without-x --without-glx

+XINERAMA_IMPLIES=      X11
 XINERAMA_USE=          XORG=xinerama
 XINERAMA_CONFIGURE_WITH=xinerama
-XINERAMA_IMPLIES=      X11

 post-install:
-       @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libag_*.so.*
+       @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libag_*.so

 .include <bsd.port.mk>
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2025-11-16 21:45:53 UTC
Better description:
3. Convert SDL*_PREVENTS to OPTIONS_RADIO_SDL.
Comment 3 Julien Nadeau 2025-11-17 02:53:38 UTC
Created attachment 265461 [details]
Revised patch for agar 1.7.1

Revised patch to update devel/agar to 1.7.1. Thanks Vladimir!
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-11-17 10:49:47 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ef4ba64b8b7af0bad49cfd8886b3f4b072ed9f3f

commit ef4ba64b8b7af0bad49cfd8886b3f4b072ed9f3f
Author:     Julien Nadeau <vedge@hypertriton.com>
AuthorDate: 2025-11-17 10:35:36 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-11-17 10:48:20 +0000

    devel/agar: Update 1.7.0 => 1.7.1, improve port

    Changelog:
    https://github.com/JulNadeauCA/libagar/blob/trunk/CHANGELOG.md#171---2025-11-15

    Improve port:
    - Replace PORTVERSION with DISTVERSION.
    - Remove GNU_CONFIGURE_MANPREFIX.
    - Convert SDL*_PREVENTS to OPTIONS_RADIO_SDL.
    - Fix warnings from portclippy.

    PR:             291038
    Co-authored-by: Vladimir Druzenko <vvd@FreeBSD.org>

 devel/agar/Makefile  |  61 ++++++++++----------
 devel/agar/distinfo  |   6 +-
 devel/agar/pkg-plist | 155 ++++++++++++++++++++++++++-------------------------
 3 files changed, 109 insertions(+), 113 deletions(-)
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2025-11-17 10:52:50 UTC
Thanks.