Bug 291267 - sysutils/tmux: Update to 3.6
Summary: sysutils/tmux: Update to 3.6
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-28 12:40 UTC by Anton Saietskii
Modified: 2025-11-29 11:49 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jrm)


Attachments
v0 (apply via 'git am') (4.14 KB, patch)
2025-11-28 12:40 UTC, Anton Saietskii
vsasjason: maintainer-approval?
Details | Diff
poudriere testport log, 14.3-R amd64 (12.04 KB, application/x-compressed)
2025-11-28 12:40 UTC, Anton Saietskii
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2025-11-28 12:40:06 UTC
Created attachment 265691 [details]
v0 (apply via 'git am')

Please make sure to apply patch via 'git am', NOT via 'git patch' or 'patch <'.

Note: in both 0aee956a78a0b6246ca181724bb468f89d33dfc3 and 0726806022243317f1a7523b8efda0c455cd938b, revision should've been bumped according to section 5.2.3.1 of Porter's Handbook.

[0]: https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-portrevision
Comment 1 Anton Saietskii 2025-11-28 12:40:43 UTC
Created attachment 265692 [details]
poudriere testport log, 14.3-R amd64
Comment 2 Joseph Mingrone freebsd_committer freebsd_triage 2025-11-28 18:17:55 UTC
Thanks.  I'm copying yasu@ here, who had already submitted a patch at https://reviews.freebsd.org/D53924.

It's fine to remove the bash completions, but we should aim for POLA for bash users.  The simplest approach would be to add a pkg-message informing users who want the completions to install the shells/bash-completion package.  I guess some people will be unhappy about having to install an omnibus bash completions port just for tmux.  An alternative would be to create something like shells/tmux-bash-completions.  It would be nice to have subpackages for this.
Comment 3 Anton Saietskii 2025-11-29 11:49:53 UTC
(In reply to Joseph Mingrone from comment #2)

Oh, I'm actually surprised that DR has been created for such a trivial update, but it's created significantly earlier than my PR anyway. I see no sense to keep both active.