Bug 291283 - devel/libvirt qemu support needs shebangfix
Summary: devel/libvirt qemu support needs shebangfix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-29 16:53 UTC by David Horn
Modified: 2025-12-05 17:03 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (novel)


Attachments
Makefile patch for SHEBANG_GLOB (455 bytes, text/plain)
2025-11-29 16:53 UTC, David Horn
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Horn 2025-11-29 16:53:36 UTC
Created attachment 265708 [details]
Makefile patch for SHEBANG_GLOB

While compiling this port with OPTIONS "qemu=on", I get a stage-qa failure:

====> Running Q/A tests (stage-qa)
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'bin/virt-qemu-sev-validate'
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'bin/virt-qemu-qmp-proxy'
*** Error code 1

Stop.
make: stopped making "all" in /usr/ports/devel/libvirt

Expected:
No failure with "qemu=on"

STR Config:
===> The following configuration options are available for libvirt-11.9.0:
     BHYVE=on: bhyve driver
     DOCS=on: Build and/or install documentation
     LIBSSH=on: libssh remote transport
     LIBSSH2=on: libssh2 remote transport
     NLS=on: Native Language Support
     NSS=off: Name Service Switch plugin
     QEMU=on: QEMU driver
     READLINE=on: Command line editing via libreadline
     SASL=off: SASL authentication support
     XEN=off: Xen support via libxl
     ZFS=on: ZFS storage driver
===> Use 'make config' to modify these settings

FreeBSD freebsd-zfs 16.0-CURRENT FreeBSD 16.0-CURRENT #2 main-n281684-e5ff8e797743: Tue Nov  4 08:27:05 EST 2025     root@freebsd-zfs:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64

I attached a proposed `Makefile` patch that works for me.   Might also be worth a pass with  portfmt(1) and/or portlint(1)
Comment 1 Roman Bogorodskiy freebsd_committer freebsd_triage 2025-11-29 17:36:17 UTC
Thanks for letting me know, I'll likely get to it somewhere next week.
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-12-04 17:13:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=16adc595b008cad7ed789d165a3308110b953aba

commit 16adc595b008cad7ed789d165a3308110b953aba
Author:     Roman Bogorodskiy <novel@FreeBSD.org>
AuthorDate: 2025-12-02 19:41:07 +0000
Commit:     Roman Bogorodskiy <novel@FreeBSD.org>
CommitDate: 2025-12-04 17:08:23 +0000

    devel/libvirt: update to 11.10.0

     - Update to 11.10.0
     - As this release adds SLIRP networking support for the bhyve driver,
       add the SLIRP option which register dependency on net/libslirp. It's
       enabled by default when the BHYVE option is enabled by default,
       and implies BHYVE.
     - Handle SHEBANG and plist entries for qemu's 'virt-qemu-qmp-proxy'
       and 'virt-qemu-sev-validate' scripts [1]

    PR:             291283 [1] (based on)
    Submitted by:   David Horn [1]
    Sponsored by:   The FreeBSD Foundation

 devel/libvirt/Makefile  | 19 +++++++++++++------
 devel/libvirt/distinfo  |  6 +++---
 devel/libvirt/pkg-plist | 22 ++++++++++++++++++++++
 3 files changed, 38 insertions(+), 9 deletions(-)
Comment 3 Roman Bogorodskiy freebsd_committer freebsd_triage 2025-12-04 17:20:35 UTC
Hope it's good now, thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-12-05 17:03:28 UTC
A commit in branch 2025Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4088a5c645d37f4c7eeb7c2901c8c551c106480d

commit 4088a5c645d37f4c7eeb7c2901c8c551c106480d
Author:     Roman Bogorodskiy <novel@FreeBSD.org>
AuthorDate: 2025-12-02 19:41:07 +0000
Commit:     Roman Bogorodskiy <novel@FreeBSD.org>
CommitDate: 2025-12-05 17:00:40 +0000

    devel/libvirt: update to 11.10.0

     - Update to 11.10.0
     - As this release adds SLIRP networking support for the bhyve driver,
       add the SLIRP option which register dependency on net/libslirp. It's
       enabled by default when the BHYVE option is enabled by default,
       and implies BHYVE.
     - Handle SHEBANG and plist entries for qemu's 'virt-qemu-qmp-proxy'
       and 'virt-qemu-sev-validate' scripts [1]

    PR:             291283 [1] (based on)
    Submitted by:   David Horn [1]
    Sponsored by:   The FreeBSD Foundation
    (cherry picked from commit 16adc595b008cad7ed789d165a3308110b953aba)

 devel/libvirt/Makefile  | 19 +++++++++++++------
 devel/libvirt/distinfo  |  6 +++---
 devel/libvirt/pkg-plist | 23 +++++++++++++++++++++++
 3 files changed, 39 insertions(+), 9 deletions(-)