Bug 291439 - tcp_syncache.c incompatible with "options RSS"
Summary: tcp_syncache.c incompatible with "options RSS"
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 16.0-CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-net (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-12-06 09:22 UTC by Marek Zarychta
Modified: 2025-12-06 17:54 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Zarychta 2025-12-06 09:22:45 UTC
It looks to me like the recent updates in TCP syncache code made it incompatible with kernels that have "options RSS" in the config enabled.
.
/usr/src/sys/netinet/tcp_syncache.c:888:4: error: call to undeclared function 'rss_proto_software_hash_v6'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
  888 |                         rss_proto_software_hash_v6(&inp->in6p_faddr,
      |                         ^
/usr/src/sys/netinet/tcp_syncache.c:898:4: error: call to undeclared function 'rss_proto_software_hash_v4'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
  898 |                         rss_proto_software_hash_v4(inp->inp_faddr,
      |                         ^
2 errors generated.
--- tcp_syncache.o ---
*** [tcp_syncache.o] Error code 1
Comment 1 commit-hook freebsd_committer freebsd_triage 2025-12-06 16:33:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=6f4debc004c31a2bd846757859e67855ab3d4c8d

commit 6f4debc004c31a2bd846757859e67855ab3d4c8d
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2025-12-06 16:32:08 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2025-12-06 16:32:08 +0000

    tcp: fix build with RSS

    PR:     291439
    Fixes:  73fe85e486d297c9c976095854c1c84007e543f0

 sys/netinet/tcp_syncache.c | 2 ++
 1 file changed, 2 insertions(+)
Comment 2 Marek Zarychta 2025-12-06 17:54:26 UTC
Thank you for the quick fix!