Created attachment 266199 [details] patch gimp-app stopped building for me. Looks like it's because misc/iso-codes changed the location of iso-codes.pc: ===== env: USE_PACKAGE_DEPENDS_ONLY=1 USER=root UID=0 GID=0 ===> gimp-app-2.10.38_8,1 depends on file: /usr/local/libdata/pkgconfig/iso-codes.pc - not found ===> Installing existing package /packages/All/iso-codes-4.18.0.pkg [zinc.ee.lbl.gov] Installing iso-codes-4.18.0... [zinc.ee.lbl.gov] Extracting iso-codes-4.18.0: .......... done ===> gimp-app-2.10.38_8,1 depends on file: /usr/local/libdata/pkgconfig/iso-codes.pc - not found *** Error code 1 Here's a quick patch.
Created attachment 266209 [details] Another candidate using proposed dependency line on FreshPorts.org Which patch looks correct?
(In reply to Tomoaki AOKI from comment #2) Nope. Commit 4ae07eaae285 must be reverted, it violates hier(7)
(In reply to Tomoaki AOKI from comment #2) I think it's better than my patch because then gimp-app doesn't require iso-codes.pc to be in any specific location.
I think 7b1b252daae should be reverted. Hier(7) says that base system .pc files should live in /usr/libdata/pkgconfig/. It is silent on ports, but I think we should be consistent. If this is not desired, then we should neuter USES=pathfix.
(In reply to Don Lewis from comment #5) Huh, we missed important point. After d48fab59daa56e0b3b6ffecef57a69c32ae9c0a7 ${LOVALBASE}/share/pkgconfig is recognised for machine-indedpended common resources. So we need adjust hier(7) to reflect this change
Looks like @sunpoet fixed this via 7b1b252daae (thanks!) zinc 6 # git diff 3076d31cda88ff4dacaf14f4e217d451245587af . diff --git a/graphics/gimp-app/Makefile b/graphics/gimp-app/Makefile index 4c7b82af4ad..092d9945d12 100644 --- a/graphics/gimp-app/Makefile +++ b/graphics/gimp-app/Makefile @@ -13,7 +13,7 @@ WWW= https://www.gimp.org/ LICENSE= GPLv3 LGPL3 LICENSE_COMB= multi -BUILD_DEPENDS= ${LOCALBASE}/libdata/pkgconfig/iso-codes.pc:misc/iso-codes \ +BUILD_DEPENDS= iso-codes>=0:misc/iso-codes \ gtkdocize:textproc/gtk-doc \ glib-networking>=0:net/glib-networking \ mypaint-brushes>0:graphics/mypaint-brushes @@ -40,7 +40,7 @@ LIB_DEPENDS_i386= libunwind.so:devel/libunwind LIB_DEPENDS_powerpc64= libunwind.so:devel/libunwind LIB_DEPENDS_powerpc64le= libunwind.so:devel/libunwind -RUN_DEPENDS= ${LOCALBASE}/libdata/pkgconfig/iso-codes.pc:misc/iso-codes \ +RUN_DEPENDS= iso-codes>=0:misc/iso-codes \ glib-networking>=0:net/glib-networking \ mypaint-brushes>0:graphics/mypaint-brushes