Bug 291966 - www/elinks: update to 0.19.0
Summary: www/elinks: update to 0.19.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Zsolt Udvari
URL: https://github.com/rkd77/elinks
Keywords:
Depends on:
Blocks:
 
Reported: 2025-12-27 02:01 UTC by Sven Siegmund
Modified: 2026-02-02 03:32 UTC (History)
3 users (show)

See Also:
jailbird: maintainer-feedback+


Attachments
Update patch (8.65 KB, patch)
2025-12-27 05:31 UTC, Dustin Marquess
jailbird: maintainer-approval+
Details | Diff
updated patch (10.68 KB, patch)
2026-01-14 02:52 UTC, Dustin Marquess
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Siegmund 2025-12-27 02:01:14 UTC
please update to 0.19.0
Comment 1 Dustin Marquess 2025-12-27 05:31:24 UTC
Created attachment 266570 [details]
Update patch

Update to 0.19.0 and fix NLS issue from #290125
Comment 2 Dustin Marquess 2025-12-27 05:32:04 UTC
Changelog: https://github.com/rkd77/elinks/releases/tag/v0.19.0
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2025-12-29 12:23:22 UTC
Thanks for your submission, Dustin.
I've two notices:
- the TEST_USES unneeded (imho this knob does not exist - if I add fakeroot doesn't install fakeroot package), the tests passed without it
- should run portlint, portfmt and portclippy (ports-mgmt/portfmt) linters, there are some issues
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2026-01-11 08:54:07 UTC
Friendly ping.
Comment 5 Dustin Marquess 2026-01-14 02:52:50 UTC
Created attachment 267128 [details]
updated patch

Latest patch with changes
Comment 6 Dustin Marquess 2026-01-14 02:54:08 UTC
I'm sorry for the delay. I've updated the patch with portfmt/portclippy changes. As for portlint, it still shows:

WARN: Makefile: EXMODE is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MEXMODE appears.
WARN: Makefile: LOCAL_CGI is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MLOCAL_CGI appears.
WARN: Makefile: NOROOT is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MNOROOT appears.
WARN: Makefile: [76]: possible direct use of command "python" found. use ${PYTHON_CMD} instead.

I'm positive that the python one is bogus, and I'm pretty sure that the other 3 option ones are also bogus, but if they're a legit, a pointer to how to fix them would be helpful, as I'm not seeing anything obviously wrong.
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2026-01-30 05:20:38 UTC
(In reply to Dustin Marquess from comment #6)
Sorry, I didn't have time but I'll check it.
Comment 8 commit-hook freebsd_committer freebsd_triage 2026-02-02 03:30:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ca14e5d170a5e96d0b625839dc28c72b7bced7d0

commit ca14e5d170a5e96d0b625839dc28c72b7bced7d0
Author:     Dustin Marquess <jailbird@fdf.net>
AuthorDate: 2026-02-02 03:26:00 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2026-02-02 03:28:48 +0000

    www/elinks: Update to 0.19.0

    Use gettext-runtime and localbase:ldflags.
    Add TEST_TARGET and remove unneeded TEST_USES.
    Add LD_FLAGS.
    Pet portlint/portfmt.

    Changelog: https://github.com/rkd77/elinks/releases/tag/v0.19.0

    PR:             291966
    Approved by:    submitter is maintainer

 www/elinks/Makefile                                | 25 +++++++++----------
 www/elinks/distinfo                                |  6 ++---
 www/elinks/files/patch-meson.build                 | 28 ++++------------------
 www/elinks/files/patch-src_document_renderer.c     |  5 ++--
 www/elinks/files/patch-src_document_renderer.h     |  4 ++--
 .../files/patch-src_js_spidermonkey_fragment.cpp   |  4 ++--
 www/elinks/files/patch-src_network_ssl_ssl.c       |  4 ++--
 www/elinks/files/patch-src_protocol_header.c       |  5 ++--
 www/elinks/files/patch-src_terminal_sixel.c        | 18 ++++----------
 9 files changed, 38 insertions(+), 61 deletions(-)
Comment 9 Zsolt Udvari freebsd_committer freebsd_triage 2026-02-02 03:32:02 UTC
Thanks for your work, Dustin! Committed.