Bug 291969 - net/linphone: update to 5.3.2
Summary: net/linphone: update to 5.3.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL: https://gitlab.linphone.org/BC/public...
Keywords:
: 291317 (view as bug list)
Depends on: 291967
Blocks: 291317
  Show dependency treegraph
 
Reported: 2025-12-27 05:51 UTC by Hiroo Ono
Modified: 2026-02-04 12:49 UTC (History)
3 users (show)

See Also:


Attachments
5.x branch update patch (25.97 KB, patch)
2025-12-27 05:51 UTC, Hiroo Ono
no flags Details | Diff
revised port patch (25.97 KB, patch)
2026-01-07 04:00 UTC, Hiroo Ono
no flags Details | Diff
patch to linphone-app/src/app/App.cpp (860 bytes, patch)
2026-02-03 21:50 UTC, Hiroo Ono
no flags Details | Diff
security/linphone: update to 5.3.2 (1.39 KB, patch)
2026-02-03 23:30 UTC, Robert Clausecker
no flags Details | Diff
267747: security/linphone: update to 5.3.2 (30.29 KB, patch)
2026-02-03 23:31 UTC, Robert Clausecker
fuz: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroo Ono 2025-12-27 05:51:12 UTC
Created attachment 266573 [details]
5.x branch update patch

Regarding the movement from Qt5 to Qt6, linphone-desktop port should also be updated to 6.0.1-CallEdition that supports Qt6.
For now, update 5.x branch to latest.
This update depends on multimedia/bcmatroska2 update (bug 291967).
Comment 1 O. Hartmann 2026-01-05 06:11:42 UTC
Hello,

I used the patch for creation a poudriere based package on 15-STABLE/CURRENT (see below). The build of port net/linphone v5.3.2 fails with this error message:

[...]
ld: error: unable to find library -ljsoncpp_lib
c++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped making "build" in /overlays/sb211/net/linphone
=>> Cleaning up wrkdir
===>  Cleaning for linphone-5.3.2,1
build of net/linphone | linphone-5.3.2,1 ended at 2026-01-04T21:11:24+00:00
build time: 00:04:09
times end [shell] (user/sys/real): 0m0.035s 0m0.006s 4m9.000s
times end [child] (user/sys/real): 4m46.861s 0m24.763s 4m9.000s
!!! build failure encountered !!!
[...]

Poudriere environment, taken from logfile of failed build net/linphone:
[...]
=>> Building net/linphone
build started at 2026-01-04T21:07:32+00:00
port directory: /overlays/sb211/net/linphone
package name: linphone-5.3.2,1
building for: FreeBSD myhost.hithere.local 15.0-STABLE FreeBSD 15.0-STABLE 1500505 amd64
maintained by: ports@FreeBSD.org
port version: 5.3.2
port revision: 0
Makefile datestamp: Dec 27 20:19:35 2025
Ports top last git commit: be7cb5054874e3e86c2f7f4acd12d0feaccbdc1a
Ports top unclean checkout: no
=>> Inspecting /pool/poudriere/data/.m/15-amd64-head-default/ref//overlays/sb211/net/linphone for modifications to git checkout... no
Port dir unclean checkout: no
Poudriere version: poudriere-git-3.4.99.20251205
Host OSVERSION: 1600007
Jail OSVERSION: 1500505
Builder Id: 04
Job Idx: 65
Jail Id (no networking)  : 40
Jail Name (no networking): 15-amd64-head-default-job-04
Jail Id (networking)     : 41
Jail Name (networking)   : 15-amd64-head-default-job-04-n

---Begin Environment---
SHELL=/bin/sh
OSVERSION=1500505
UNAME_v=FreeBSD 15.0-STABLE 1500505
UNAME_r=15.0-STABLE
BLOCKSIZE=K
MAIL=/var/mail/root
MM_CHARSET=UTF-8
LANG=C.UTF-8
STATUS=1
HOME=/root
PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
MAKE_OBJDIR_CHECK_WRITABLE=0
LOCALBASE=/usr/local
USER=root
POUDRIERE_NAME=poudriere-git
POUDRIERE_VERSION=3.4.99.20251205
MAKEOBJDIRPREFIX=/pool/sources/15-STABLE/obj/
MASTERMNT=/pool/poudriere/data/.m/15-amd64-head-default/ref
LC_COLLATE=C
POUDRIERE_BUILD_TYPE=bulk
PACKAGE_BUILDING=yes
SAVED_TERM=screen
OUTPUT_REDIRECTED_STDERR=4
OUTPUT_REDIRECTED=1
PWD=/pool/poudriere/data/.m/15-amd64-head-default/04/.p
OUTPUT_REDIRECTED_STDOUT=3
P_PORTS_FEATURES=FLAVORS SUBPACKAGES SELECTED_OPTIONS
MASTERNAME=15-amd64-head-default
OLDPWD=/pool/poudriere/data/.m/15-amd64-head-default/ref/.p/pool
POUDRIERE_PKGNAME=poudriere-git-3.4.99.20251205
PREFIX=/usr/local
POUDRIEREPATH=/usr/local/bin/poudriere
---End Environment---
[...]
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2026-01-05 06:40:54 UTC
(In reply to O. Hartmann from comment #1)
Try to add:
USES+=localbase
or
USES+=localbase:ldflags
Comment 3 Hiroo Ono 2026-01-05 10:55:16 UTC
(In reply to O. Hartmann from comment #1)
You also need bug 291968.
Comment 4 Hiroo Ono 2026-01-05 10:57:07 UTC
(In reply to Hiroo Ono from comment #3)
And bug 296917. Without this patch, it builds but fails to run.
Comment 5 Hiroo Ono 2026-01-07 04:00:11 UTC
Created attachment 266883 [details]
revised port patch

Sorry, I verified the problem with "jsoncpp_lib". Here is revised patch.
Comment 6 Hiroo Ono 2026-01-07 04:01:29 UTC
(In reply to Hiroo Ono from comment #5)

Forgot to add that without the patch in bug 291967, the built linphone will not start.
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2026-01-30 12:49:42 UTC
*** Bug 291317 has been marked as a duplicate of this bug. ***
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2026-01-30 12:51:58 UTC
Patch looks fine.
May I assign maintainership over this port to you?
Comment 9 Hiroo Ono 2026-01-30 15:18:10 UTC
(In reply to Robert Clausecker from comment #8)
I do not have a counter part to test the application. All I can do is just an invoking test.
If that is OK, I will be the maintainer.
Comment 10 Robert Clausecker freebsd_committer freebsd_triage 2026-01-31 07:41:43 UTC
(In reply to Hiroo Ono from comment #9)

That is indeed sufficient!
Build test went ok, will commit next week probably.
Comment 11 Robert Clausecker freebsd_committer freebsd_triage 2026-02-01 10:38:27 UTC
There seems to be a build failure on arm64 FreeBSD 14.3:

[ 15% 29/180] /usr/local/libexec/ccache/c++ -DENABLE_QT_KEYCHAIN -DENABLE_UPDATE_CHECK -DENABLE_VIDEO -I/wrkdirs/usr/ports/net/linphone/work/.build/linphone-app -I/wrkdirs/usr/ports/net/linphone/work/linphone-desktop-5.3.2/linphone-app -I/wrkdirs/usr/ports/net/linphone/work/.build/linphone-app/app-library_autogen/include -I/wrkdirs/usr/ports/net/linphone/work/linphone-desktop-5.3.2/linphone-app/src -I/usr/local/include/OpenGL -I/wrkdirs/usr/ports/net/linphone/work/linphone-desktop-5.3.2/linphone-app/include -I/wrkdirs/usr/ports/net/linphone/work/.build/external/ispell/include -isystem /usr/local/include -isystem /usr/local/include/belle-sip -isystem /usr/local/include/libxml2 -isystem /usr/local/include/qt5 -isystem /usr/local/include/qt5/QtTextToSpeech -isystem /usr/local/include/qt5/QtCore -isystem /usr/local/lib/qt5/mkspecs/freebsd-clang -isystem /usr/local/include/qt5/QtQmlModels -isystem /usr/local/include/qt5/QtQml -isystem /usr/local/include/qt5/QtNetwork -isystem /usr/local/include/qt5/QtGui -isystem /usr/local/include/qt5/QtQuick -isystem /usr/local/include/qt5/QtWidgets -isystem /usr/local/include/qt5/QtQuickControls2 -isystem /usr/local/include/qt5/QtSvg -isystem /usr/local/include/qt5/QtConcurrent -isystem /usr/local/include/qt5/QtTest -isystem /usr/local/include/qt5/QtMultimedia -isystem /usr/local/include/qt5/QtDBus -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -pthread -DTEXTTOSPEECH_ENABLED -DQMLMODELS_ENABLED -O2 -pipe -fstack-protector-strong -fno-strict-aliasing   -DNDEBUG -DNDEBUG -DQT_NO_DEBUG -std=gnu++14 -fPIC -MD -MT linphone-app/CMakeFiles/app-library.dir/src/app/App.cpp.o -MF linphone-app/CMakeFiles/app-library.dir/src/app/App.cpp.o.d -o linphone-app/CMakeFiles/app-library.dir/src/app/App.cpp.o -c /wrkdirs/usr/ports/net/linphone/work/linphone-desktop-5.3.2/linphone-app/src/app/App.cpp
FAILED: [code=1] linphone-app/CMakeFiles/app-library.dir/src/app/App.cpp.o 
/usr/local/libexec/ccache/c++ -DENABLE_QT_KEYCHAIN -DENABLE_UPDATE_CHECK -DENABLE_VIDEO -I/wrkdirs/usr/ports/net/linphone/work/.build/linphone-app -I/wrkdirs/usr/ports/net/linphone/work/linphone-desktop-5.3.2/linphone-app -I/wrkdirs/usr/ports/net/linphone/work/.build/linphone-app/app-library_autogen/include -I/wrkdirs/usr/ports/net/linphone/work/linphone-desktop-5.3.2/linphone-app/src -I/usr/local/include/OpenGL -I/wrkdirs/usr/ports/net/linphone/work/linphone-desktop-5.3.2/linphone-app/include -I/wrkdirs/usr/ports/net/linphone/work/.build/external/ispell/include -isystem /usr/local/include -isystem /usr/local/include/belle-sip -isystem /usr/local/include/libxml2 -isystem /usr/local/include/qt5 -isystem /usr/local/include/qt5/QtTextToSpeech -isystem /usr/local/include/qt5/QtCore -isystem /usr/local/lib/qt5/mkspecs/freebsd-clang -isystem /usr/local/include/qt5/QtQmlModels -isystem /usr/local/include/qt5/QtQml -isystem /usr/local/include/qt5/QtNetwork -isystem /usr/local/include/qt5/QtGui -isystem /usr/local/include/qt5/QtQuick -isystem /usr/local/include/qt5/QtWidgets -isystem /usr/local/include/qt5/QtQuickControls2 -isystem /usr/local/include/qt5/QtSvg -isystem /usr/local/include/qt5/QtConcurrent -isystem /usr/local/include/qt5/QtTest -isystem /usr/local/include/qt5/QtMultimedia -isystem /usr/local/include/qt5/QtDBus -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -pthread -DTEXTTOSPEECH_ENABLED -DQMLMODELS_ENABLED -O2 -pipe -fstack-protector-strong -fno-strict-aliasing   -DNDEBUG -DNDEBUG -DQT_NO_DEBUG -std=gnu++14 -fPIC -MD -MT linphone-app/CMakeFiles/app-library.dir/src/app/App.cpp.o -MF linphone-app/CMakeFiles/app-library.dir/src/app/App.cpp.o.d -o linphone-app/CMakeFiles/app-library.dir/src/app/App.cpp.o -c /wrkdirs/usr/ports/net/linphone/work/linphone-desktop-5.3.2/linphone-app/src/app/App.cpp
/wrkdirs/usr/ports/net/linphone/work/linphone-desktop-5.3.2/linphone-app/src/app/App.cpp:299:16: error: comparison between pointer and integer ('char *(*)(int, int)' and 'int')
  299 |                 if (timezone != -QTimeZone::systemTimeZone().offsetFromUtc(QDateTime::currentDateTime())) {
      |                     ~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


Please check.
Comment 12 Robert Clausecker freebsd_committer freebsd_triage 2026-02-03 10:29:47 UTC
The build error is related to D44281 resp. base a34940a9756ac8edce36fec176949ee82e9235b4.  The definition of the timezone symbol has changed in FreeBSD 15 to be standards compliant.  I'll see if I can find a workaround.
Comment 13 Robert Clausecker freebsd_committer freebsd_triage 2026-02-03 10:31:07 UTC
Another error: if git is installed while this port is built, configuration fails as follows:

fatal: not a git repository (or any of the parent directories): .git
CMake Error at /usr/local/share/BCToolbox/cmake/BCToolboxCMakeUtils.cmake:144 (message):
  fail to get GIT describe version
Call Stack (most recent call first):
  linphone-app/build/CMakeLists.txt:49 (bc_compute_full_version)


-- Configuring incomplete, errors occurred!

Please patch out the bits that try to get a GIT version.  Ports should never attempt this.
Comment 14 Hiroo Ono 2026-02-03 11:24:13 UTC
(In reply to Robert Clausecker from comment #13)
Thank you.

I will cope with timezone and git problem.
As I am a little bit busy, it may take some time. Sorry.

About the timezone value, I think doing some math between the output of gmtime and localtime solves the problem. I will try later.
Comment 15 Robert Clausecker freebsd_committer freebsd_triage 2026-02-03 21:04:03 UTC
Okay, I fixed these issues and also added some missing libraries to the dependency list (stage-qa was unhappy).  Will commit with my next batch.
Comment 16 Hiroo Ono 2026-02-03 21:50:23 UTC
Created attachment 267746 [details]
patch to linphone-app/src/app/App.cpp

Thank you.

By the way, I was about to build test with
* a patch to App.cpp (attached)
* commenting out bc_compute_full_version in linphone-app/build/CMakeLists.txt
  (maybe, build/CMakeLists.txt needs some more tweak)

Hope this is similar to your changes. I will check after it is committed.
Comment 17 Robert Clausecker freebsd_committer freebsd_triage 2026-02-03 23:30:15 UTC
Created attachment 267747 [details]
security/linphone: update to 5.3.2

See here for the patch I plan to commit.
The git issue can be avoided by sabotaging cmake's attempt to find git.
The timezone issue by skipping the check, which should be harmless.

That said, I'm not sure if your patch would work.  Branches of if-statements that aren't taken must still compile and "bc_timezone = timezone;" does not compile if timezone is a function.
Comment 18 Robert Clausecker freebsd_committer freebsd_triage 2026-02-03 23:31:09 UTC
Created attachment 267748 [details]
267747: security/linphone: update to 5.3.2

Sorry, uploaded the wrong patch by accident.
Comment 19 commit-hook freebsd_committer freebsd_triage 2026-02-04 12:42:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e9f8f7c74a9bf21a2a5cae60cda3e76dd4cbd9cd

commit e9f8f7c74a9bf21a2a5cae60cda3e76dd4cbd9cd
Author:     Hiroo Ono <hiroo.ono+freebsd@gmail.com>
AuthorDate: 2026-01-31 16:26:26 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2026-02-04 12:41:14 +0000

    net/linphone: update to 5.3.2

     - work around build failure on FreeBSD <15 (requires the XSI timezone
       symbol, not the old BSD one, cf. D44281)
     - work around build failure when git is installed
     - fix dependencies

    Changelog: https://gitlab.linphone.org/BC/public/linphone-desktop/-/blob/5.3.2/CHANGELOG.md?ref_type=tags

    PR:             291969, 291317

 net/linphone/Makefile                              | 98 +++++++++++++++-------
 net/linphone/distinfo                              |  8 +-
 net/linphone/files/patch-CMakeLists.txt            | 34 ++++----
 .../files/patch-external_ispell_config.h (new)     | 11 +++
 .../files/patch-linphone-app_CMakeLists.txt (new)  | 93 ++++++++++++++++++++
 ...ch-linphone-app_cmake_FindBCToolbox.cmake (new) | 13 +++
 ...-linphone-app_cmake_FindLibLinphone.cmake (new) | 28 +++++++
 ...nphone-app_cmake_FindMediastreamer2.cmake (new) | 29 +++++++
 ...h-linphone-app_cmake_FindQtKeychain.cmake (new) | 35 ++++++++
 ..._builder_linphone__package_CMakeLists.txt (new) | 11 +++
 .../files/patch-linphone-app_src_app_App.cpp (new) | 21 +++++
 ...ch-linphone-app_src_app_logger_Logger.cpp (new) | 11 +++
 ..._components_other_clipboard_Clipboard.cpp (new) | 11 +++
 ...omponents_other_desktop-tools_DesktopTools.hpp} |  4 +-
 ...ents_other_spell-checker_SpellChecker.cpp (new) | 11 +++
 ...ents_other_spell-checker_SpellChecker.hpp (new) | 20 +++++
 ...phone-app_src_components_vfs_VfsUtils.hpp (new) | 11 +++
 net/linphone/pkg-plist                             | 21 +++++
 18 files changed, 422 insertions(+), 48 deletions(-)
Comment 20 Robert Clausecker freebsd_committer freebsd_triage 2026-02-04 12:49:40 UTC
Thank you for your contribution.