Bug 292071 - boost-libs: make boost type_traits build with clang 21
Summary: boost-libs: make boost type_traits build with clang 21
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: FreeBSD Office Team
URL:
Keywords:
Depends on:
Blocks: 292067
  Show dependency treegraph
 
Reported: 2025-12-31 14:51 UTC by Dimitry Andric
Modified: 2026-01-01 02:49 UTC (History)
2 users (show)

See Also:
fluffy: maintainer-feedback+


Attachments
boost-libs: make boost type_traits build with clang 21 (9.94 KB, patch)
2025-12-31 14:52 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2025-12-31 14:51:55 UTC
Recent versions of clang made -Wenum-constexpr-conversion errors into a
hard error, as was announced several versions ago.

Boost type_traits has two instances where it attempts to convert
out-of-range enum values, leading to errors similar to:

    In file included from ../src/lib/dhcpsrv/csv_lease_file6.cc:9:
    In file included from ../src/lib/dhcpsrv/dhcpsrv_log.h:11:
    In file included from ../src/lib/log/macros.h:10:
    In file included from ../src/lib/log/logger.h:19:
    In file included from ../src/lib/log/log_formatter.h:19:
    In file included from /usr/local/include/boost/lexical_cast.hpp:33:
    In file included from /usr/local/include/boost/lexical_cast/try_lexical_convert.hpp:31:
    In file included from /usr/local/include/boost/lexical_cast/detail/converter_numeric.hpp:31:
    In file included from /usr/local/include/boost/type_traits/make_unsigned.hpp:14:
    /usr/local/include/boost/type_traits/is_signed.hpp:37:25: error: in-class initializer for static data member is not a constant expression
       37 |    static const no_cv_t minus_one = (static_cast<no_cv_t>(-1));
          |                         ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~
    /usr/local/include/boost/type_traits/is_signed.hpp:45:60: note: in instantiation of template class 'boost::detail::is_signed_values<isc::dhcp::Lease::Type>' requested here
       45 |    BOOST_STATIC_CONSTANT(bool, value = (!(::boost::detail::is_signed_values<T>::minus_one  > boost::detail::is_signed_values<T>::zero)));
          |                                                            ^
    /usr/local/include/boost/config/detail/suffix.hpp:410:72: note: expanded from macro 'BOOST_STATIC_CONSTANT'
      410 | #     define BOOST_STATIC_CONSTANT(type, assignment) static const type assignment
          |                                                                        ^
    /usr/local/include/boost/type_traits/is_signed.hpp:74:40: note: in instantiation of template class 'boost::detail::is_signed_helper<isc::dhcp::Lease::Type>' requested here
       74 |    BOOST_STATIC_CONSTANT(bool, value = type::value);
          |                                        ^
    /usr/local/include/boost/config/detail/suffix.hpp:410:72: note: expanded from macro 'BOOST_STATIC_CONSTANT'
      410 | #     define BOOST_STATIC_CONSTANT(type, assignment) static const type assignment
          |                                                                        ^
    /usr/local/include/boost/type_traits/is_signed.hpp:79:85: note: in instantiation of template class 'boost::detail::is_signed_impl<isc::dhcp::Lease::Type>' requested here
       79 | template <class T> struct is_signed : public integral_constant<bool, boost::detail::is_signed_impl<T>::value> {};
          |                                                                                     ^
    /usr/local/include/boost/lexical_cast/detail/converter_lexical_streams.hpp:315:44: note: in instantiation of template class 'boost::is_signed<isc::dhcp::Lease::Type>' requested here
      315 |         typename boost::enable_if_c<boost::is_signed<Type>::value && !boost::is_enum<Type>::value, bool>::type
          |                                            ^
    /usr/local/include/boost/lexical_cast/detail/converter_lexical.hpp:449:67: note: while substituting deduced template arguments into function template 'stream_in' [with Type = isc::dhcp::Lease::Type]
      449 |                 -> decltype(std::declval<optimized_src_stream&>().stream_in(std::declval<lcast::exact<T>>()), optimized_src_stream{});
          |                                                                   ^
    /usr/local/include/boost/lexical_cast/detail/converter_lexical.hpp:454:46: note: while substituting explicitly-specified template arguments into function template 'detect_type'
      454 |             using from_src_stream = decltype(detect_type<Source>(1));
          |                                              ^
    /usr/local/include/boost/lexical_cast/try_lexical_convert.hpp:67:20: note: in instantiation of template class 'boost::detail::lexical_converter_impl<std::string, isc::dhcp::Lease::Type>' requested here
       67 |             return caster_type::try_convert(arg, result);
          |                    ^
    /usr/local/include/boost/lexical_cast.hpp:42:41: note: in instantiation of function template specialization 'boost::conversion::detail::try_lexical_convert<std::string, isc::dhcp::Lease::Type>' requested here
       42 |         if (!boost::conversion::detail::try_lexical_convert(arg, result)) {
          |                                         ^
    ../src/lib/util/csv_file.h:243:34: note: in instantiation of function template specialization 'boost::lexical_cast<std::string, isc::dhcp::Lease::Type>' requested here
      243 |             values_[at] = boost::lexical_cast<std::string>(value);
          |                                  ^
    ../src/lib/dhcpsrv/csv_lease_file6.cc:54:9: note: in instantiation of function template specialization 'isc::util::CSVRow::writeAt<isc::dhcp::Lease::Type>' requested here
       54 |     row.writeAt(getColumnIndex("lease_type"), lease.type_);
          |         ^
    /usr/local/include/boost/type_traits/is_signed.hpp:37:38: note: integer value -1 is outside the valid range of values [0, 3] for the enumeration type 'Type'
       37 |    static const no_cv_t minus_one = (static_cast<no_cv_t>(-1));
          |                                      ^

This is while compiling net/kea, but other users of boost type traits
may also have the same issue.

There is an upstream bug report at:
https://github.com/boostorg/type_traits/issues/202

and an outstanding pull request at:
https://github.com/boostorg/type_traits/pull/199

Apply the latter as a diff, to work around the problem. Bump
PORTREVISION to make dependents recompile.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2025-12-31 14:52:19 UTC
Created attachment 266685 [details]
boost-libs: make boost type_traits build with clang 21
Comment 2 Andrey Pevnev 2025-12-31 14:55:24 UTC
Hm, I'm not sure why I've got a maintainer feedback request on this, I'm not qualified to to approve boost-libs :)
Comment 3 Dimitry Andric freebsd_committer freebsd_triage 2025-12-31 15:01:06 UTC
(In reply to Andrey Pevnev from comment #2)
Yeah, it's pretty weird. Maybe because your username begins with 'a' and therefore you are the first victim that Bugzilla could find? :)

In any case, devel/boost-libs does not have a MAINTAINER entry. Looking at the history, it seems that Dima is a frequent committer, and also maintainer of boost-build. I hope Dima doesn't mind being added to CC.
Comment 4 Dima Panov freebsd_committer freebsd_triage 2025-12-31 15:13:01 UTC
(In reply to Dimitry Andric from comment #3)

I'll take a look ASAP but have no objections for your patch

BTW, Boost-1.90.0 is almost ready to hit the ports, WIP in https://github.com/fluffykhv/freebsd-ports-boost

Maintaines is office@, set in boost-all/common.mk
Anyway I'm only one active developer for Boost and LibreOffice
Comment 5 Dimitry Andric freebsd_committer freebsd_triage 2025-12-31 15:37:06 UTC
(In reply to Dima Panov from comment #4)
Since the upstream pull request has not yet been merged, it will also not be in boost 1.90.0. But I would expect the patches to apply cleanly to 1.90.0 too. The affected headers in type_traits have not been modified for quite a while.
Comment 6 Dima Panov freebsd_committer freebsd_triage 2025-12-31 21:12:40 UTC
(In reply to Dimitry Andric from comment #5)
Feel free to commit patch btw
Comment 7 commit-hook freebsd_committer freebsd_triage 2026-01-01 02:07:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ab934769498d910cfb2e9e6493dd1fedc3cbc5f7

commit ab934769498d910cfb2e9e6493dd1fedc3cbc5f7
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2025-12-31 14:13:21 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2026-01-01 02:05:54 +0000

    boost-libs: make boost type_traits build with clang 21

    Recent versions of clang made -Wenum-constexpr-conversion errors into a
    hard error, as was announced several versions ago.

    Boost type_traits has two instances where it attempts to convert
    out-of-range enum values, leading to errors similar to:

        In file included from ../src/lib/dhcpsrv/csv_lease_file6.cc:9:
        In file included from ../src/lib/dhcpsrv/dhcpsrv_log.h:11:
        In file included from ../src/lib/log/macros.h:10:
        In file included from ../src/lib/log/logger.h:19:
        In file included from ../src/lib/log/log_formatter.h:19:
        In file included from /usr/local/include/boost/lexical_cast.hpp:33:
        In file included from /usr/local/include/boost/lexical_cast/try_lexical_convert.hpp:31:
        In file included from /usr/local/include/boost/lexical_cast/detail/converter_numeric.hpp:31:
        In file included from /usr/local/include/boost/type_traits/make_unsigned.hpp:14:
        /usr/local/include/boost/type_traits/is_signed.hpp:37:25: error: in-class initializer for static data member is not a constant expression
           37 |    static const no_cv_t minus_one = (static_cast<no_cv_t>(-1));
              |                         ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~
        /usr/local/include/boost/type_traits/is_signed.hpp:45:60: note: in instantiation of template class 'boost::detail::is_signed_values<isc::dhcp::Lease::Type>' requested here
           45 |    BOOST_STATIC_CONSTANT(bool, value = (!(::boost::detail::is_signed_values<T>::minus_one  > boost::detail::is_signed_values<T>::zero)));
              |                                                            ^
        /usr/local/include/boost/config/detail/suffix.hpp:410:72: note: expanded from macro 'BOOST_STATIC_CONSTANT'
          410 | #     define BOOST_STATIC_CONSTANT(type, assignment) static const type assignment
              |                                                                        ^
        /usr/local/include/boost/type_traits/is_signed.hpp:74:40: note: in instantiation of template class 'boost::detail::is_signed_helper<isc::dhcp::Lease::Type>' requested here
           74 |    BOOST_STATIC_CONSTANT(bool, value = type::value);
              |                                        ^
        /usr/local/include/boost/config/detail/suffix.hpp:410:72: note: expanded from macro 'BOOST_STATIC_CONSTANT'
          410 | #     define BOOST_STATIC_CONSTANT(type, assignment) static const type assignment
              |                                                                        ^
        /usr/local/include/boost/type_traits/is_signed.hpp:79:85: note: in instantiation of template class 'boost::detail::is_signed_impl<isc::dhcp::Lease::Type>' requested here
           79 | template <class T> struct is_signed : public integral_constant<bool, boost::detail::is_signed_impl<T>::value> {};
              |                                                                                     ^
        /usr/local/include/boost/lexical_cast/detail/converter_lexical_streams.hpp:315:44: note: in instantiation of template class 'boost::is_signed<isc::dhcp::Lease::Type>' requested here
          315 |         typename boost::enable_if_c<boost::is_signed<Type>::value && !boost::is_enum<Type>::value, bool>::type
              |                                            ^
        /usr/local/include/boost/lexical_cast/detail/converter_lexical.hpp:449:67: note: while substituting deduced template arguments into function template 'stream_in' [with Type = isc::dhcp::Lease::Type]
          449 |                 -> decltype(std::declval<optimized_src_stream&>().stream_in(std::declval<lcast::exact<T>>()), optimized_src_stream{});
              |                                                                   ^
        /usr/local/include/boost/lexical_cast/detail/converter_lexical.hpp:454:46: note: while substituting explicitly-specified template arguments into function template 'detect_type'
          454 |             using from_src_stream = decltype(detect_type<Source>(1));
              |                                              ^
        /usr/local/include/boost/lexical_cast/try_lexical_convert.hpp:67:20: note: in instantiation of template class 'boost::detail::lexical_converter_impl<std::string, isc::dhcp::Lease::Type>' requested here
           67 |             return caster_type::try_convert(arg, result);
              |                    ^
        /usr/local/include/boost/lexical_cast.hpp:42:41: note: in instantiation of function template specialization 'boost::conversion::detail::try_lexical_convert<std::string, isc::dhcp::Lease::Type>' requested here
           42 |         if (!boost::conversion::detail::try_lexical_convert(arg, result)) {
              |                                         ^
        ../src/lib/util/csv_file.h:243:34: note: in instantiation of function template specialization 'boost::lexical_cast<std::string, isc::dhcp::Lease::Type>' requested here
          243 |             values_[at] = boost::lexical_cast<std::string>(value);
              |                                  ^
        ../src/lib/dhcpsrv/csv_lease_file6.cc:54:9: note: in instantiation of function template specialization 'isc::util::CSVRow::writeAt<isc::dhcp::Lease::Type>' requested here
           54 |     row.writeAt(getColumnIndex("lease_type"), lease.type_);
              |         ^
        /usr/local/include/boost/type_traits/is_signed.hpp:37:38: note: integer value -1 is outside the valid range of values [0, 3] for the enumeration type 'Type'
           37 |    static const no_cv_t minus_one = (static_cast<no_cv_t>(-1));
              |                                      ^

    This is while compiling net/kea, but other users of boost type traits
    may also have the same issue.

    There is an upstream bug report at:
    https://github.com/boostorg/type_traits/issues/202

    and an outstanding pull request at:
    https://github.com/boostorg/type_traits/pull/199

    Apply the latter as a diff, to work around the problem. Bump
    PORTREVISION to make dependents recompile.

    PR:             292071
    Approved by:    fluffy (maintainer)
    MFH:            2025Q4

 devel/boost-libs/Makefile                          |  2 +-
 .../patch-boost_type__traits_is__signed.hpp (new)  | 48 ++++++++++++++++++++++
 ...patch-boost_type__traits_is__unsigned.hpp (new) | 42 +++++++++++++++++++
 3 files changed, 91 insertions(+), 1 deletion(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2026-01-01 02:08:16 UTC
A commit in branch 2025Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=55367bfa224d3f85d4cbd55b83f63ed6026b7b7c

commit 55367bfa224d3f85d4cbd55b83f63ed6026b7b7c
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2025-12-31 14:13:21 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2026-01-01 02:07:29 +0000

    boost-libs: make boost type_traits build with clang 21

    Recent versions of clang made -Wenum-constexpr-conversion errors into a
    hard error, as was announced several versions ago.

    Boost type_traits has two instances where it attempts to convert
    out-of-range enum values, leading to errors similar to:

        In file included from ../src/lib/dhcpsrv/csv_lease_file6.cc:9:
        In file included from ../src/lib/dhcpsrv/dhcpsrv_log.h:11:
        In file included from ../src/lib/log/macros.h:10:
        In file included from ../src/lib/log/logger.h:19:
        In file included from ../src/lib/log/log_formatter.h:19:
        In file included from /usr/local/include/boost/lexical_cast.hpp:33:
        In file included from /usr/local/include/boost/lexical_cast/try_lexical_convert.hpp:31:
        In file included from /usr/local/include/boost/lexical_cast/detail/converter_numeric.hpp:31:
        In file included from /usr/local/include/boost/type_traits/make_unsigned.hpp:14:
        /usr/local/include/boost/type_traits/is_signed.hpp:37:25: error: in-class initializer for static data member is not a constant expression
           37 |    static const no_cv_t minus_one = (static_cast<no_cv_t>(-1));
              |                         ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~
        /usr/local/include/boost/type_traits/is_signed.hpp:45:60: note: in instantiation of template class 'boost::detail::is_signed_values<isc::dhcp::Lease::Type>' requested here
           45 |    BOOST_STATIC_CONSTANT(bool, value = (!(::boost::detail::is_signed_values<T>::minus_one  > boost::detail::is_signed_values<T>::zero)));
              |                                                            ^
        /usr/local/include/boost/config/detail/suffix.hpp:410:72: note: expanded from macro 'BOOST_STATIC_CONSTANT'
          410 | #     define BOOST_STATIC_CONSTANT(type, assignment) static const type assignment
              |                                                                        ^
        /usr/local/include/boost/type_traits/is_signed.hpp:74:40: note: in instantiation of template class 'boost::detail::is_signed_helper<isc::dhcp::Lease::Type>' requested here
           74 |    BOOST_STATIC_CONSTANT(bool, value = type::value);
              |                                        ^
        /usr/local/include/boost/config/detail/suffix.hpp:410:72: note: expanded from macro 'BOOST_STATIC_CONSTANT'
          410 | #     define BOOST_STATIC_CONSTANT(type, assignment) static const type assignment
              |                                                                        ^
        /usr/local/include/boost/type_traits/is_signed.hpp:79:85: note: in instantiation of template class 'boost::detail::is_signed_impl<isc::dhcp::Lease::Type>' requested here
           79 | template <class T> struct is_signed : public integral_constant<bool, boost::detail::is_signed_impl<T>::value> {};
              |                                                                                     ^
        /usr/local/include/boost/lexical_cast/detail/converter_lexical_streams.hpp:315:44: note: in instantiation of template class 'boost::is_signed<isc::dhcp::Lease::Type>' requested here
          315 |         typename boost::enable_if_c<boost::is_signed<Type>::value && !boost::is_enum<Type>::value, bool>::type
              |                                            ^
        /usr/local/include/boost/lexical_cast/detail/converter_lexical.hpp:449:67: note: while substituting deduced template arguments into function template 'stream_in' [with Type = isc::dhcp::Lease::Type]
          449 |                 -> decltype(std::declval<optimized_src_stream&>().stream_in(std::declval<lcast::exact<T>>()), optimized_src_stream{});
              |                                                                   ^
        /usr/local/include/boost/lexical_cast/detail/converter_lexical.hpp:454:46: note: while substituting explicitly-specified template arguments into function template 'detect_type'
          454 |             using from_src_stream = decltype(detect_type<Source>(1));
              |                                              ^
        /usr/local/include/boost/lexical_cast/try_lexical_convert.hpp:67:20: note: in instantiation of template class 'boost::detail::lexical_converter_impl<std::string, isc::dhcp::Lease::Type>' requested here
           67 |             return caster_type::try_convert(arg, result);
              |                    ^
        /usr/local/include/boost/lexical_cast.hpp:42:41: note: in instantiation of function template specialization 'boost::conversion::detail::try_lexical_convert<std::string, isc::dhcp::Lease::Type>' requested here
           42 |         if (!boost::conversion::detail::try_lexical_convert(arg, result)) {
              |                                         ^
        ../src/lib/util/csv_file.h:243:34: note: in instantiation of function template specialization 'boost::lexical_cast<std::string, isc::dhcp::Lease::Type>' requested here
          243 |             values_[at] = boost::lexical_cast<std::string>(value);
              |                                  ^
        ../src/lib/dhcpsrv/csv_lease_file6.cc:54:9: note: in instantiation of function template specialization 'isc::util::CSVRow::writeAt<isc::dhcp::Lease::Type>' requested here
           54 |     row.writeAt(getColumnIndex("lease_type"), lease.type_);
              |         ^
        /usr/local/include/boost/type_traits/is_signed.hpp:37:38: note: integer value -1 is outside the valid range of values [0, 3] for the enumeration type 'Type'
           37 |    static const no_cv_t minus_one = (static_cast<no_cv_t>(-1));
              |                                      ^

    This is while compiling net/kea, but other users of boost type traits
    may also have the same issue.

    There is an upstream bug report at:
    https://github.com/boostorg/type_traits/issues/202

    and an outstanding pull request at:
    https://github.com/boostorg/type_traits/pull/199

    Apply the latter as a diff, to work around the problem. Bump
    PORTREVISION to make dependents recompile.

    PR:             292071
    Approved by:    fluffy (maintainer)
    MFH:            2025Q4

    (cherry picked from commit ab934769498d910cfb2e9e6493dd1fedc3cbc5f7)

 .../patch-boost_type__traits_is__signed.hpp (new)  | 48 ++++++++++++++++++++++
 ...patch-boost_type__traits_is__unsigned.hpp (new) | 42 +++++++++++++++++++
 2 files changed, 90 insertions(+)