The mailman rc.d script has two problems: `service mailman start` prints ugly error if the service is already started `service mailman status` returns code 0 if the service is not running, 1 if it is running (see https://gitlab.com/mailman/mailman/-/blob/master/src/mailman/bin/master.py#L105) This causes problems with tools like ansible, where the service module assumes rc 1 means that the service isn't running and 0 that it is.
Created attachment 267082 [details] Update rc.d script
Should be easy to do, just need to wait for some more time when my committers became available to review PRs I'm to commit.
(In reply to Älven from comment #2) Friendly bump
so, any chance to get this comitted?
Yes. I'm very sorry for so long delay. Tested OK. Now waiting for approval from my mentors.
Created attachment 270694 [details] Fixed rc script, now removing *.orig files and using `status` instead of `start` Took a better look at the patch. Don't know why I used `start` in mailman_status, but apparently it didn't break anything. It should still be `status`. Also added back in a post-patch step to remove *.orig files
Created attachment 271848 [details] Rebase on current
Sorry, my mentors may be too busy to review this PR. I'm returning it to pool and hope other committers will land it quickly.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ae15f89980dff827563056d876641f942a70c6dd commit ae15f89980dff827563056d876641f942a70c6dd Author: Einar Bjarni Halldórsson <einar@isnic.is> AuthorDate: 2026-08-16 19:09:12 +0000 Commit: Jochen Neumeister <joneum@FreeBSD.org> CommitDate: 2026-08-16 19:10:45 +0000 mail/mailman3: Update rc.d script Fix the exit code of "service mailman status". Mailman's own status command exits 0 when it is not running and 1 when it is, which is the inverse of the rc.subr convention. Wrap it so that a running master yields 0, as service(8) consumers such as Ansible expect. Also add a start_precmd that detects an already running master via the pidfile, so that "service mailman start" no longer dumps a full click usage block on a second invocation. PR: 292404 Sponsored by: Netzkommune GmbH mail/mailman3/Makefile | 2 +- mail/mailman3/files/mailman.in | 25 ++++++++++++++++++++++++- 2 files changed, 25 insertions(+), 2 deletions(-)
A commit in branch 2026Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=15033a23ac4f603e23ad01a7b649acd95be83b25 commit 15033a23ac4f603e23ad01a7b649acd95be83b25 Author: Einar Bjarni Halldórsson <einar@isnic.is> AuthorDate: 2026-08-16 19:09:12 +0000 Commit: Jochen Neumeister <joneum@FreeBSD.org> CommitDate: 2026-08-16 19:15:13 +0000 mail/mailman3: Update rc.d script Fix the exit code of "service mailman status". Mailman's own status command exits 0 when it is not running and 1 when it is, which is the inverse of the rc.subr convention. Wrap it so that a running master yields 0, as service(8) consumers such as Ansible expect. Also add a start_precmd that detects an already running master via the pidfile, so that "service mailman start" no longer dumps a full click usage block on a second invocation. PR: 292404 Sponsored by: Netzkommune GmbH (cherry picked from commit ae15f89980dff827563056d876641f942a70c6dd) mail/mailman3/Makefile | 2 +- mail/mailman3/files/mailman.in | 25 ++++++++++++++++++++++++- 2 files changed, 25 insertions(+), 2 deletions(-)