Created attachment 267759 [details] remove BSDTIME from src/include/os_bsd.h A recent commit (46b4e04137ac569c1bbcd3965c087e785c70bc55) removed a bogus timezone() definition in src/include/misc.h. While this works, it is cleaner to avoid defining HAS_BSDTIME altogether. gettimeofday(2) is obsolescent according to our manpage so this is consistent with the comment in spice. FWIW, I reverted the misc.h in my system and tested but for some reason git diff didn't catch it!
I do think we want gettimeofday(), what does the program do if it fails to detect gettimeofday()? I doubt this project supports clock_gettime(). It may fall back to just time() instead, reducing accuracy to seconds. Note that the bug is not in gettimeofday(), it's in timezone() which this port does not use.
Created attachment 267775 [details] Replace BSDTIME with SYSVTIME A quick grep for BSDTIME over the spice code appears to show that it doesn't use gettimeofday() at all. The only difference with SYSVTIME is the bogus timezone definition in src/include/misc.h.