With clang 21 comms/bladerf fails to build, with errors similar to: /wrkdirs/usr/ports/comms/bladerf/work/bladeRF-2025.10/host/utilities/bladeRF-cli/src/cmd/flash_image.c:71:35: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare] 71 | if (val[i] >= 'a' || val[i] <= 'f') { | ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ This is a logic error: the logical operator should be `&&` here. It has been proposed as an upstream pull request: https://github.com/Nuand/bladeRF/pull/1045, but it is not yet merged.
Created attachment 268307 [details] comms/bladerf: fix build with clang 21
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1d3ebc89481999cd5696097cf653b8e97f5eb8cb commit 1d3ebc89481999cd5696097cf653b8e97f5eb8cb Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2026-02-23 21:02:54 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2026-03-13 08:32:26 +0000 comms/bladerf: fix build with clang 21 With clang 21 comms/bladerf fails to build, with errors similar to: /wrkdirs/usr/ports/comms/bladerf/work/bladeRF-2025.10/host/utilities/bladeRF-cli/src/cmd/flash_image.c:71:35: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare] 71 | if (val[i] >= 'a' || val[i] <= 'f') { | ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ This is a logic error: the logical operator should be `&&` here. It has been proposed as an upstream pull request: https://github.com/Nuand/bladeRF/pull/1045, but it is not yet merged. PR: 293393 Approved by: maintainer timeout (2 weeks) MFH: 2026Q1 ...ch-host_utilities_bladeRF-cli_src_cmd_flash__image.c (new) | 11 +++++++++++ 1 file changed, 11 insertions(+)