Comment 1 Vladimir Druzenko 2026-02-25 12:38:50 UTC

11 files in plist - move it from Makefile to pkg-plist file.

Created attachment 268361 [details]
update grzip move to codeberg add NLS knob and pkg-plist

> 11 files in plist - move it from Makefile to pkg-plist file.
Agreed. 11 is far too many. Done.

Same patch as before. But move PLIST to pkg-plist
Files affected:

Makefile
distinfo
pkg-plist

Thank you for taking this, Vladimir!

Comment 3 Vladimir Druzenko 2026-02-26 01:30:50 UTC

Can you replace in Makefile "-Wl,-soname,libgrzip.so" with "-Wl,-soname,libgrzip.so.0"?
soname with digit is better.

Makefile:
PORTNAME=       grzip
DISTVERSION=    0.3.1
CATEGORIES=     archivers
MASTER_SITES=   https://codeberg.org/BSDforge/${PORTNAME}/archive/${DISTVERSION}${EXTRACT_SUFX}?dummy=/

MAINTAINER=     portmaster@BSDforge.com
COMMENT=        Efficient file compressor
WWW=            https://BSDforge.com/projects/archivers/grzip

LICENSE=        LGPL21

USES=           gettext-runtime localbase:ldflags
USE_LDCONFIG=   yes
ALL_TARGET=     ${PORTNAME}
CFLAGS+=        -fPIC
LDFLAGS+=       -lintl
WRKSRC=         ${WRKDIR}/${PORTNAME}

OPTIONS_DEFINE= NLS
OPTIONS_SUB=    yes

NLS_USES=               gettext-tools
NLS_CONFIGURE_ENABLE=   nls

post-patch:
        @${REINPLACE_CMD} -e 's|DESTDIR|PREFIX|g;/^CC.*=/d;/^OPTFLAGS/s|-O2||;/^CFLAGS/s|=|+=|'\
                -e '/^PREFIX=/d;/^LDFLAGS/s|=|+=|' \
                -e 's|-Wl,-soname,libgrzip.so|-Wl,-soname,libgrzip.so.0|' \
                ${WRKSRC}/Makefile ${WRKSRC}/po/Makefile

do-install:
        ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${STAGEDIR}${PREFIX}/bin
        ${LN} -sf ${PORTNAME} ${STAGEDIR}${PREFIX}/bin/grunzip
        ${LN} -sf ${PORTNAME} ${STAGEDIR}${PREFIX}/bin/grzcat
        ${INSTALL_SCRIPT} ${grztar grzdiff grzgrep grzmore:L:S|^|${WRKSRC}/scripts/|} \
                ${STAGEDIR}${PREFIX}/bin
        ${INSTALL_PROGRAM} ${WRKSRC}/lib${PORTNAME}.so ${STAGEDIR}${PREFIX}/lib/lib${PORTNAME}.so.0
        ${LN} -sf lib${PORTNAME}.so.0 ${STAGEDIR}${PREFIX}/lib/lib${PORTNAME}.so
        ${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.h ${STAGEDIR}${PREFIX}/include

do-install-NLS-on:
        (cd ${WRKSRC}/po; ${SETENV} ${MAKE_ENV} ${MAKE} PREFIX="${STAGEDIR}${PREFIX}" install)

.include <bsd.port.mk>

pkg-plist:
bin/grunzip
bin/grzcat
bin/grzdiff
bin/grzgrep
bin/grzip
bin/grzmore
bin/grztar
include/grzip.h
lib/libgrzip.so
lib/libgrzip.so.0
%%NLS%%share/locale/fr/LC_MESSAGES/grzip.mo

Created attachment 268364 [details]
update grzip to 0.3.1

> soname with digit is better
Agreed. I should have caught that. I'll incorporate that into
the next version.
This patch incorporates all your suggestions. A HUGE thank you
for doing all this. I'd have done it if you'd have asked. But maybe
it was easier to just do it, than explain. I thought about the
USES and NLS_USES changes you made. But it somehow seemed more
efficient the way I chose. But I trust your judgement here. :)

Thanks again, Vladimir.

Comment 5 commit-hook 2026-02-26 19:12:15 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5a83e5118a3a3c319d7236b1f281bba1dde50e64

commit 5a83e5118a3a3c319d7236b1f281bba1dde50e64
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2026-02-26 19:02:46 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2026-02-26 19:11:27 +0000

    archivers/grzip: Update 0.3.0 => 0.3.1

    Changelog:
    https://codeberg.org/BSDforge/grzip/src/tag/0.3.1/Changelog

    Port changes:
    - Move to Codeberg.
    - Add NLS option.
    - Use USES+=localbase instead of CFLAGS/LDFLAGS.
    - Move plist from Makefile to pkg-plist - 11 files.
    - Split long lines.
    - Fix soname: libgrzip.so.0 instead of libgrzip.so.

    PR:             293434
    Co-authored-by: Vladimir Druzenko <vvd@FreeBSD.org>

 archivers/grzip/Makefile        | 43 ++++++++++++++++++++++++++---------------
 archivers/grzip/distinfo        |  5 +++--
 archivers/grzip/pkg-plist (new) | 11 +++++++++++
 3 files changed, 41 insertions(+), 18 deletions(-)

Comment 6 Vladimir Druzenko 2026-02-26 19:14:02 UTC

Thanks.