Created attachment 268344 [details] Update net-mgmt/py-napalm from 5.0.0 to 5.1.0 Also adds a new dependency on py-setuptools.
(In reply to Nick Hilliard from comment #0) Hi Nick, thank you for the patch, which LGTM. I have one question: Is there a specific reason why py-junos-eznc was omitted? In the requirements.txt, the version requirement for py-junos-eznc is ">=2.7.4" and the net-mgmt/py-junos-eznc port needs to be updated as well. I took a closer look at your patch and have already checked a few things. As far as I can see, py-junos-eznc >= 2.7.4 is needed for Python 3.13+, where "telnetlib" is no longer available, and py-junos-eznc >= 2.7.4 ships "telnetlib" as vendored module. (Whether the use of telnet still makes sense today is another story...) - Results of test suite of py-napalm with current junos-eznc 2.7.0 in the ports tree: > [...] >../../../../../../../usr/local/lib/python3.11/site-packages/jnpr/junos/transport/tty_telnet.py:2 > /usr/local/lib/python3.11/site-packages/jnpr/junos/transport/tty_telnet.py:2: DeprecationWarning: 'telnetlib' is deprecated and slated for removal in Python 3.13 > import telnetlib > [...] > === 524 passed, 80 skipped, 4 warnings in 2.83s === - Results of test suite of py-napalm with latest junos-eznc 2.7.6: > === 524 passed, 80 skipped, 3 warnings in 2.85s === Regardless of these facts, I'd like to take this opportunity to update py-junos-eznc and py-ncclient together with py-napalm in order to obtain a up-to-date status of all components. I'll create the corresponding bugs in a few minutes and link them to this bug.
> I have one question: Is there a specific reason why py-junos-eznc was omitted? yeah, once you start updating py package dependencies, things rapidly spiral out of control. There were a lot of other py dependencies which I skipped over due to lack of time. The root problem I ran into was that the napalm integration in py-salt was stack-dumping unless py-setuptools was installed. The patch I uploaded to this PR passed the "wfm" test, including logging into some junos boxes.
(In reply to Nick Hilliard from comment #2) All right, thanks for the additional info. No problem with regard to the Python dependencies - it's indeed like going down a rabbit hole. The bugs for updating py-ncclient and py-junos-eznc are now available and the latter one is linked with this bug. As soon as I receive feedback from the maintainer or the timeout is reached, I'll commit everything in one go.