Created attachment 268425 [details] emulators/mame: Update to 0.286 Update emulators/mame to 0.286 Sort pkg-plist portlint: OK portclippy: OK poudriere: OK
(In reply to Laurent Chardon from comment #0) > Sort pkg-plist Incorrect sorting.
Hello Vlad, Thanks for the review. Would you mind explaining how the sorting is incorrect? I thought that I was allowed to sort this way. From the porter's handbook: "It is recommended to keep all the filenames in this file sorted alphabetically. It will make verifying changes when upgrading the port much easier. The sorting should be applied after variable expansion takes place. The framework does this correctly when the package list is generated automatically". This seems to be a recommendation, not a mandatory port requirement. The difficulty I have is to sort *after the variable expansion*. Is there a tool to do it? I tried plist-sort from ports-mgmt/ports-tools but it ate the %% around %%MAMEDATA%%, so I stopped trusting it, as I don't know what other things it might not be doing well, and it's too easy to miss single instances of incorrect variable naming. I also can't use "make makeplist" because of the port options that are not handled by that method. So the alternatives are sorting before variable expansion, which is what I did, or sorting manually. I'll be honest, I prefer not to sort manually if I don't have to. In the end, the goal is to make verifying changes easier. Sorting before variable expansion achieves this goal. Your thoughts? Thanks!
Hi! I don't know of any such tools, so I sort them manually... During updates, the number of changed files is usually not very large, so it's not that difficult. But not always. P.S. Vlad != Vladimir, Vlad = Vladislav.
Sorry about your name! I mistakenly thought that you signed Vlad. I'll keep it in mind for next time.
Created attachment 268436 [details] pkg-plist sorted with recommended method I fixed plist-sort and re-sorted pkg-plist in the way recommended in the porting handbook. I will do a PR upstream for plist-sort.
This change look weird: @@ -38,6 +38,7 @@ USES= compiler:c++17-lang gmake jpeg llvm:min=16 localbase \ USE_GITHUB= yes GH_ACCOUNT= mamedev GH_TAGNAME= ${PORTNAME}${DISTVERSION:S/.//} +USE_SDL= sdl2 ttf2 USE_SDL= sdl2 USE_XORG= x11 xext xi xinerama xrender Also there is: _EMULATORS_USE= GL=gl \ SDL=ttf2 Why is this change necessary?
It is a new dependency: #include <SDL2/SDL_ttf.h> in src/osd/modules/font/font_sdl.cpp
Oh, I see what you mean. It's wrong. Give me a second.
Created attachment 268451 [details] emulators/mame: improved patch for 0.286 Remove redundant USE_SDL and move USE_SDL=ttf2 outside of the EMULATORS option due to new base dependency.
> This month, we’ve added support for SDL3, which will be used by default when > building on macOS (the default is still SDL2 on other UNIX-like platforms). > You can choose SDL2 or SDL3 by adding OSD=sdl or OSD=sdl3 to your build options, > respectively. There may be some teething issues, so if you build against SDL3 > and things break, let us know. Switch to SDL3 soon?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1e8f8561742ab5aba90c097d3213dc4562c6fb87 commit 1e8f8561742ab5aba90c097d3213dc4562c6fb87 Author: Laurent Chardon <laurent.chardon@gmail.com> AuthorDate: 2026-03-01 14:31:31 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2026-03-01 14:31:31 +0000 emulators/mame: Update 0.284 => 0.286 Release Notes: https://www.mamedev.org/?p=560 Sort plist. PR: 293508 emulators/mame/Makefile | 8 +++----- emulators/mame/distinfo | 6 +++--- emulators/mame/pkg-plist | 49 +++++++++++++++++++++++++++++------------------- 3 files changed, 36 insertions(+), 27 deletions(-)
(In reply to Vladimir Druzenko from comment #10) I'll probably make it an option at first, until it's stable. Thanks for the review and commit!
Thanks for your contribution!