Bug 293563 - emulators/libretro-pcsx2: various issues with the port (bundling dependencies, setting user only flags, missing dependencies)
Summary: emulators/libretro-pcsx2: various issues with the port (bundling dependencies...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-03-03 18:24 UTC by Benjamin Takacs
Modified: 2026-03-03 20:03 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (beyert)


Attachments
WIP emulators/libretro-pcsx2: improve port (5.63 KB, patch)
2026-03-03 18:24 UTC, Benjamin Takacs
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Takacs 2026-03-03 18:24:26 UTC
Created attachment 268508 [details]
WIP emulators/libretro-pcsx2: improve port

I wanted to fix bug 277204 for libretro-pcsx2 and while at it fix the missing dependency on perl, which is pulled in on the oficial builders as transitive dependency via the WEBKIT option of wxgtk30, when I noticed that it also bundles dependencies. So I wanted to fix that too, sadly that isn't that easy, as cmake doesn't add the include path for glib anymore with my changes and so the build fails.

So I request you to finish unbundling dependencies.

Improvemnts already done in the work in progress patch:
* explicitly depend on perl
* don't set WITH_CCACHE_BUILD (It is a user setting, not a port one)
* use arch helpers to set LDFLAGS and CXXFLAGS for i386
* remove 3rdparty dir in post-patch
* remove patches for 3rdparty
* remove mentions of 3rdparty in CMakeLists.txt
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2026-03-03 18:51:30 UTC
(In reply to Benjamin Takacs from comment #0)
1. Use
EXTRACT_AFTER_ARGS=     --exclude 3rdparty \
                        --no-same-owner --no-same-permissions
instead of:
post-patch:
	${RM} -r ${WRKSRC}/3rdparty

2. Check Makefile with portclippy, portfmt and portlint.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2026-03-03 19:04:06 UTC
Can you open WWW=https://github.com/libretro/pcsx2 ?
I got 404.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2026-03-03 19:06:25 UTC
Maybe upstream moved to https://github.com/PCSX2/pcsx2 ?
Comment 4 Benjamin Takacs 2026-03-03 19:26:18 UTC
(In reply to Vladimir Druzenko from comment #2)
https://docs.libretro.com/library/lrps2/ reads like the project renamed to lrps2 and the  repo moved to https://github.com/libretro/ps2

when you try to access the docs for the old name https://docs.libretro.com/library/pcsx2/ you get a page linking to lrps2.

(In reply to Vladimir Druzenko from comment #3)
That repo would be the normal version of the emulator, which we have in the ports tree as emulators/pcsx2, emulators/libretro-pcsx2 is the libretro core variant of the emulator to use with retroarch.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2026-03-03 20:03:25 UTC
(In reply to Benjamin Takacs from comment #4)
Thanks for info.
Lets update WWW, GH_PROJECT, maybe even PORTNAME and port itself to newer commit.