Bug 293566 - security/sssd2: fails to build with samba > 4.16
Summary: security/sssd2: fails to build with samba > 4.16
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gleb Popov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-03-03 22:02 UTC by Dan Langille
Modified: 2026-03-06 16:11 UTC (History)
2 users (show)

See Also:
arrowd: maintainer-feedback+

Attachments
Patch series (8.33 KB, patch)
2026-03-06 13:34 UTC, Gleb Popov 		arrowd: maintainer-approval? (samba)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Langille freebsd_committer freebsd_triage 2026-03-03 22:02:44 UTC 
With: "DEFAULT_VERSIONS+= samba=4.23", the build failures look like this:

/usr/local/include/samba4/ndr.h:842:25: error: unknown type name 'uid_t'; did you mean 'pid_t'?


If I remove that samba reference, it build just fine.

There are other errors in that build, but that is the first one.

I've tested on FreeBSD 14.3 and 15.0 always using a fresh checkout of the ports tree. The log file is offline, but if requested, I can get that online for review.
Comment 1 Dan Langille freebsd_committer freebsd_triage 2026-03-03 22:54:50 UTC 
It fails to build with samba419, samba420, samba422
Comment 2 Gleb Popov freebsd_committer freebsd_triage 2026-03-04 05:47:36 UTC 
I think, we should reapply https://github.com/freebsd/freebsd-ports/commit/fd6a710e199bdba2b2df37a481038e743da895dd to all the newer samba ports.
Comment 3 Dan Langille freebsd_committer freebsd_triage 2026-03-04 16:55:51 UTC 
FYI, sssd2-2.9.6_6 (as found in 2026Q1) builds just fine on head with samba-4.2.3

It does not build with sssd2-2.12.0

To get our ports tree building again, we have downgraded sssd2
Comment 4 Gleb Popov freebsd_committer freebsd_triage 2026-03-06 13:34:29 UTC 
Created attachment 268573 [details]
Patch series
Comment 5 Dan Langille freebsd_committer freebsd_triage 2026-03-06 15:01:51 UTC 
(In reply to Gleb Popov from comment #4)

This builds with samba 4.23 on FreeBSD 15.0 for me.  The resulting package itself has not yet been tested. That will come later.

I will test building with other samba versions next.