Created attachment 269237 [details] Patch Adds a new port for hl, a JSON log viewer and processor. https://github.com/pamburus/hl Verified working via manual testing and "poudriere testport" with 15.0-RELEASE on amd64, testing with 14.4-RELEASE on amd64 is currently running.
Created attachment 269239 [details] Patch
Aborted testing on 14.4-RELEASE since Poudriere (still) insists on building Rust from scratch, which I don't have the resources, time and energy costs for doing.
Created attachment 269669 [details] Patch Overcome by events, upstream updated to v0.36.1 in the meantime.
Hi, Thanks for your submission. I have tested the build in Poudriere on 14.4-RELEASE-amd64-main-d80fc2ccfd50 and it seems OK including `make test`. Not tested runtime since I am not an user of this program. running 4 tests test src/themecfg/theme.rs - themecfg::theme::Theme::load_with_overlays (line 105) ... ignored test src/themecfg/mod.rs - themecfg (line 15) - compile ... ok test src/themecfg/mod.rs - themecfg (line 23) - compile ... ok test src/settings.rs - settings::DisplayVariant (line 681) ... ok test result: ok. 3 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.00s all doctests ran in 13.21s; merged doctests compilation took 13.20s I wonder if it's better to create OPTIONS for BASH, ZSH and FISH shell completions since some ports have them. Also you should add the port to the category/Makefile since FreeBSD package builders would not see it when the time comes to build it so it would not be built at all. Also I would remove the "+" from LIB_DEPENDS, preferably. diff --git a/sysutils/Makefile b/sysutils/Makefile index 2e3208bca59f..173e276abd0d 100644 --- a/sysutils/Makefile +++ b/sysutils/Makefile @@ -517,6 +517,7 @@ SUBDIR += hid-tools SUBDIR += highlnk SUBDIR += hilite + SUBDIR += hl SUBDIR += host-setup SUBDIR += hostctl SUBDIR += hourglass diff --git a/sysutils/hl/Makefile b/sysutils/hl/Makefile index 8db12efb43f2..8660645884bf 100644 --- a/sysutils/hl/Makefile +++ b/sysutils/hl/Makefile @@ -10,7 +10,7 @@ WWW= https://github.com/pamburus/hl LICENSE= MIT LICENSE_FILE= ${WRKSRC}/LICENSE -LIB_DEPENDS+= libzstd.so:archivers/zstd +LIB_DEPENDS= libzstd.so:archivers/zstd USES= cargo USE_GITHUB= yes Otherwise, all OK for me. Thanks.
Created attachment 270333 [details] Updated patch
(In reply to Yusuf Yaman from comment #4) Thanks for taking the port submission on. > Not tested runtime since I am not an user of this program. I have tested the built package on multiple systems and it works as expected. > I wonder if it's better to create OPTIONS for BASH, ZSH and FISH shell completions since some ports have them. I'd argue against that. What default would you set? If you set no default and make all the completions optional they become meaningless as every user of a respective shell would either have to compile a custom package or (more likely) disregard them completely and set them up manually. Having them as options would be strictly cleaner but gains practically nothing as the overhead created by them measures in the single-digit kilobytes. In my view, we should either leave them out entirely or include all of them. > Also you should add the port to the category/Makefile since FreeBSD package builders would not see it when the time comes to build it so it would not be built at all. Didn't know about that, thanks for the pointer! > Also I would remove the "+" from LIB_DEPENDS, preferably. Done. Please see updated patch.
(In reply to Marcel Bischoff from comment #6) > Thanks for taking the port submission on. You're welcome :) > > Not tested runtime since I am not an user of this program. > I have tested the built package on multiple systems and it works as expected. Thank you! > > Also you should add the port to the category/Makefile since FreeBSD package > > builders would not see it when the time comes to build it so it would not be > > built at all. > Didn't know about that, thanks for the pointer! You're welcome :) > > Also I would remove the "+" from LIB_DEPENDS, preferably. > Done. Please see updated patch. Thank you. > > I wonder if it's better to create OPTIONS for BASH, ZSH and FISH shell > > completions since some ports have them. > I'd argue against that. What default would you set? If you set no default and > make all the completions optional they become meaningless as every user of a > respective shell would either have to compile a custom package or (more > likely) disregard them completely and set them up manually. Having them as > options would be strictly cleaner but gains practically nothing as the > overhead created by them measures in the single-digit kilobytes. In my view, > we should either leave them out entirely or include all of them. Hmm. We can install all of them by default and ones who build their own packages can turn them off if they want, but I agree with that they are very small files. FreeBSD builders would compile the package with all options (bash,zsh,fish completions) turned on so package would have all of them. Both ways are OK for me, now. Thank you.
(In reply to Yusuf Yaman from comment #7) If you insist on it, we can certainly do it but I cannot find prior art in the ports tree. Compare textproc/sd and sysutils/fd for example. Those ports do install the completions regardless. I've never created a port with options for post-install processing and would need assistance with that. But again, I believe this would just induce complexity where none is required.
(In reply to Marcel Bischoff from comment #8) > If you insist on it, we can certainly do it but I cannot find prior art in > the ports tree. Compare textproc/sd and sysutils/fd for example. Those ports > do install the completions regardless. Sorry, I am not insisting on it, it's fine then. I see, it's a preference of maintainers then, I guess. > I've never created a port with options for post-install processing and would > need assistance with that. But again, I believe this would just induce > complexity where none is required. I see, okay, let's keep them so.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1a267945d5b1e4229ed31520ccf5e4b954ad1126 commit 1a267945d5b1e4229ed31520ccf5e4b954ad1126 Author: Marcel Bischoff <marcel@herrbischoff.com> AuthorDate: 2026-03-30 20:10:11 +0000 Commit: Yusuf Yaman <nxjoseph@FreeBSD.org> CommitDate: 2026-05-11 12:24:42 +0000 sysutils/hl: Add new port hl is a fast and powerful log viewer and processor that converts JSON logs or logfmt logs into a clear human-readable format. PR: 294147 Reported by: Marcel Bischoff <marcel@herrbischoff.com> Approved by: osa (mentor) sysutils/Makefile | 1 + sysutils/hl/Makefile (new) | 46 +++ sysutils/hl/Makefile.crates (new) | 394 +++++++++++++++++++ sysutils/hl/distinfo (new) | 791 ++++++++++++++++++++++++++++++++++++++ sysutils/hl/pkg-descr (new) | 2 + 5 files changed, 1234 insertions(+)
Committed, thanks!