Bug 294251 - mail/fetchmail: update to 6.6.3
Summary: mail/fetchmail: update to 6.6.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yusuf Yaman
URL: https://gitlab.com/fetchmail/fetchmai...
Keywords:
Depends on:
Blocks:
 
Reported: 2026-04-04 21:40 UTC by Corey Halpin
Modified: 2026-04-08 18:51 UTC (History)
4 users (show)

See Also:
vvd: maintainer-feedback+


Attachments
Proposed patch (849 bytes, patch)
2026-04-04 21:40 UTC, Corey Halpin
no flags Details | Diff
0001-mail-fetchmail-Update-6.6.1-6.6.3.patch (2.45 KB, patch)
2026-04-08 17:04 UTC, Yusuf Yaman
chalpin: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Corey Halpin 2026-04-04 21:40:17 UTC
Created attachment 269366 [details]
Proposed patch

After applying the attached mail/fetchmail passes 'poudriere testport' on amd64 under 15.0, 14.4, 14.3, and 13.5 for the following configurations:
  - Default settings 
  - ssl=base, GSSAPI_MIT
  - ssl=base, GSSAPI_NONE
  - ssl=openssl, GSSAPI_MIT
  - ssl=openssl, GSSAPI_NONE
  - WolfSSL
  - no NLS
  - no DOCS

mail/fetchmailconf passes 'poudriere testport' on amd64 under 15.0, 14.4, 14.3, and 13.5 with default settings.

Built package also works in my testing.


Changes since 6.6.1 (reproduced from upstream NEWS):

fetchmail-6.6.3 (released 2026-04-01, 32388 LoC):

## COMPATIBILITY:
* fetchmail can now be built with OpenSSL 4.0.0 (tested as of -beta1).


fetchmail-6.6.2 (released 2025-12-09, 32386 LoC):

## BUGFIX:
* fetchmail 6.6.0 and 6.6.1 could not be configured without SSL, it would break
  compiling sink.c.  Fix compilation.  Report by Toralf Förster, analysis and
  different patch suggested by Holger Hoffstätte, fixes #86.
  https://bugs.gentoo.org/967258 and
  https://gitlab.com/fetchmail/fetchmail/-/issues/86
Comment 1 Yusuf Yaman freebsd_committer freebsd_triage 2026-04-05 17:19:38 UTC
Hi,

Thank you for your submission.

I have tested build of the patch in Poudriere (14.3-RELEASE-p9, amd64, main(c927d063a7ee)) and it seems OK.

Maybe while we are here, we can replace <bsd.port.pre.mk> and <bsd.port.post.mk> with <bsd.port.options.mk> and <bsd.port.mk>.

I need to ask for approval from my mentors first.

Thanks.

diff --git a/mail/fetchmail/Makefile b/mail/fetchmail/Makefile
index 58cb8bb189ff..97839d8f420d 100644
--- a/mail/fetchmail/Makefile
+++ b/mail/fetchmail/Makefile
@@ -105,7 +105,7 @@ post-install-DOCS-on:

 .endif

-.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>

 .if ${PORT_OPTIONS:MOPIE} && ${MASTERDIR} == ${.CURDIR} && ${OPSYS} == FreeBSD
 . if ${OSVERSION} >= 1400072
@@ -114,4 +114,4 @@ CPPFLAGS+=  -I${LOCALBASE}/include
 . endif
 .endif

-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2026-04-05 18:10:42 UTC
Try this:
+USES+=          localbase:ldflags
+LDFLAGS+=       -Wl,--as-needed
-LDFLAGS+=       -L${LOCALBASE}/lib -Wl,--as-needed
-CPPFLAGS+=      -I${LOCALBASE}/include
Comment 3 Yusuf Yaman freebsd_committer freebsd_triage 2026-04-05 18:26:17 UTC
(In reply to Vladimir Druzenko from comment #2)
Yes, this way works too.
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2026-04-08 15:51:53 UTC
(In reply to Yusuf Yaman from comment #3)
Add this to patch too.
Comment 5 Yusuf Yaman freebsd_committer freebsd_triage 2026-04-08 17:04:52 UTC
Created attachment 269510 [details]
0001-mail-fetchmail-Update-6.6.1-6.6.3.patch

(In reply to Vladimir Druzenko from comment #4)
Okay.
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2026-04-08 18:16:34 UTC
LGMT.
If the maintainer has no objections, then you can commit.
Comment 7 Corey Halpin 2026-04-08 18:41:49 UTC
Comment on attachment 269510 [details]
0001-mail-fetchmail-Update-6.6.1-6.6.3.patch

Looks good to me, builds correctly in poudriere, built package works in my testing.

I have no objections - thank you for the improvements!
Comment 8 commit-hook freebsd_committer freebsd_triage 2026-04-08 18:50:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1acb7a259430803e8efda6a8c35025119d99ac53

commit 1acb7a259430803e8efda6a8c35025119d99ac53
Author:     Corey Halpin <chalpin@cs.wisc.edu>
AuthorDate: 2026-04-05 17:01:49 +0000
Commit:     Yusuf Yaman <nxjoseph@FreeBSD.org>
CommitDate: 2026-04-08 18:49:28 +0000

    mail/fetchmail: Update 6.6.1 => 6.6.3

    While here:
    * Use <bsd.port.options.mk> instead.
    * Add USES=localbase:ldflags instead.

    Changelog:
    * Fix compilation without SSL.
    * Can now be built with OpenSSL 4.0.0.
    https://gitlab.com/fetchmail/fetchmail/-/blob/6.6.3/NEWS?ref_type=tags

    PR:             294251
    Reported by:    Corey Halpin <chalpin@cs.wisc.edu> (maintainer)
    Approved by:    vvd (co-mentor)

 mail/fetchmail/Makefile | 11 +++++------
 mail/fetchmail/distinfo |  6 +++---
 2 files changed, 8 insertions(+), 9 deletions(-)
Comment 9 Yusuf Yaman freebsd_committer freebsd_triage 2026-04-08 18:51:55 UTC
(In reply to Vladimir Druzenko from comment #6)
Thank you.

(In reply to Corey Halpin from comment #7)
Thanks.

Committed.