Bug 294252 - deskutils/py-vit: update to 2.3.4
Summary: deskutils/py-vit: update to 2.3.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yusuf Yaman
URL: https://github.com/vit-project/vit/re...
Keywords:
Depends on:
Blocks:
 
Reported: 2026-04-04 21:49 UTC by Thierry Dussuet
Modified: 2026-04-06 23:16 UTC (History)
3 users (show)

See Also:
vvd: maintainer-feedback+
nxjoseph: merge-quarterly+


Attachments
2.3.4 patch (1.19 KB, patch)
2026-04-04 21:49 UTC, Thierry Dussuet
no flags Details | Diff
2.3.4 patch 2 (1.58 KB, patch)
2026-04-05 22:04 UTC, Thierry Dussuet
no flags Details | Diff
2.3.4 patch 3 (1.58 KB, patch)
2026-04-06 18:33 UTC, Thierry Dussuet
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Dussuet 2026-04-04 21:49:05 UTC
Created attachment 269367 [details]
2.3.4 patch

Update from 2.3.3 to 2.3.4

Changelog:
Tue Mar 17 2026: Support Taskwarrior 'grey' color aliases
Sun Jan 11 2026: Guard empty autocomplete tab options
Tue Jun 24 2025: fix #368 default to string type for UDA if no type configured
Mon Jun 02 2025: Use 'is not None' for None checks
Sun Jun 01 2025: Fix UDA string sorting (after reset)
Tue Apr 22 2025: don't strip trailing commas from UDA values, they are valid
Tue Apr 22 2025: add uda_config attribute to TaskParser instance
Sun Feb 23 2025: modernize build script
Sun Feb 23 2025: vit-watchdog: fix signal include
Comment 1 Yusuf Yaman freebsd_committer freebsd_triage 2026-04-05 16:58:01 UTC
Hi,

Thank you for your submission.

I have tested the build of patch in Poudriere (14.3-RELEASE-p9, amd64, main(c927d063a7ee)) and it seems OK.

There are very small adjustments can be done:

1. Remove GH_PROJECT, since PORTNAME is "vit" and I guess GH_PROJECT defaults to PORTNAME and make it unneeded here.

2. A space can be added before last line .include <bsd.port.mk>.

diff --git a/deskutils/py-vit/Makefile b/deskutils/py-vit/Makefile
index 91ae53819025..251c60006946 100644
--- a/deskutils/py-vit/Makefile
+++ b/deskutils/py-vit/Makefile
@@ -19,8 +19,8 @@ RUN_DEPENDS=  task:deskutils/taskwarrior \
 USES=          python:3.5+,run
 USE_GITHUB=    yes
 GH_ACCOUNT=    vit-project
-GH_PROJECT=    vit
 USE_PYTHON=    autoplist concurrent distutils

 NO_ARCH=       yes
+
 .include <bsd.port.mk>

I need to ask for approval from my mentors first.

Thanks.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2026-04-05 18:06:28 UTC
-USES=          python:3.5+,run
+USES=          python:run
Min version in ports is 3.10.
Comment 3 Yusuf Yaman freebsd_committer freebsd_triage 2026-04-05 18:11:00 UTC
(In reply to Vladimir Druzenko from comment #2)
Thanks for the clarification. I also thought about it and checked if python3.5 even exist. I should have asked that!
Comment 4 Thierry Dussuet 2026-04-05 22:04:32 UTC
Created attachment 269395 [details]
2.3.4 patch 2
Comment 5 Thierry Dussuet 2026-04-05 22:06:31 UTC
Thank you for your kind feedback, Yusuf and Vladimir - noted and changed in the attached patch
Comment 6 Yusuf Yaman freebsd_committer freebsd_triage 2026-04-06 13:31:39 UTC
(In reply to Thierry Dussuet from comment #5)
You are welcome, thank you!

What about also removing :run too? I see BUILD_DEPENDS has setuptools containing.

If it's just USES=python, it defaults to python:build,run,test

# Mk/Uses/python.mk
> # If build, run and test are omitted, Python will be added as BUILD_DEPENDS,
> # RUN_DEPENDS and TEST_DEPENDS.
Comment 7 Thierry Dussuet 2026-04-06 18:33:22 UTC
Created attachment 269420 [details]
2.3.4 patch 3

True, that makes it simpler, thank you - adjusted
Comment 8 commit-hook freebsd_committer freebsd_triage 2026-04-06 20:36:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=96442118053ee250fae90bb16f86f369727fda17

commit 96442118053ee250fae90bb16f86f369727fda17
Author:     Thierry Dussuet <thierry.dussuet@protonmail.com>
AuthorDate: 2026-04-04 21:37:00 +0000
Commit:     Yusuf Yaman <nxjoseph@FreeBSD.org>
CommitDate: 2026-04-06 20:35:48 +0000

    deskutils/py-vit: Update 2.3.3 => 2.3.4

    Changelog:
    https://github.com/vit-project/vit/releases/tag/v2.3.4

    Port changes:
    * Remove unneeded GH_PROJECT.
    * Remove extra arguments from USES=python.

    PR:             294252
    Reported by:    Thierry Dussuet <thierry.dussuet@protonmail.com> (maintainer)
    Approved by:    maintainer, vvd (co-mentor)

 deskutils/py-vit/Makefile | 6 +++---
 deskutils/py-vit/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2026-04-06 23:15:28 UTC
A commit in branch 2026Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=61a4663c80bb5a07f991ab5d0d97a55e21865f6b

commit 61a4663c80bb5a07f991ab5d0d97a55e21865f6b
Author:     Thierry Dussuet <thierry.dussuet@protonmail.com>
AuthorDate: 2026-04-04 21:37:00 +0000
Commit:     Yusuf Yaman <nxjoseph@FreeBSD.org>
CommitDate: 2026-04-06 23:14:57 +0000

    deskutils/py-vit: Update 2.3.3 => 2.3.4

    Changelog:
    https://github.com/vit-project/vit/releases/tag/v2.3.4

    Port changes:
    * Remove unneeded GH_PROJECT.
    * Remove extra arguments from USES=python.

    PR:             294252
    Reported by:    Thierry Dussuet <thierry.dussuet@protonmail.com> (maintainer)
    Approved by:    maintainer, vvd (co-mentor)

    (cherry picked from commit 96442118053ee250fae90bb16f86f369727fda17)

 deskutils/py-vit/Makefile | 6 +++---
 deskutils/py-vit/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
Comment 10 Yusuf Yaman freebsd_committer freebsd_triage 2026-04-06 23:16:17 UTC
Committed, thanks.