Bug 294285 - ports-mgmt/portlint: When the WRKDIR (work/work-py311/etc) is present portlint shouldn't dive into it and report all files
Summary: ports-mgmt/portlint: When the WRKDIR (work/work-py311/etc) is present portlin...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-04-06 17:34 UTC by Yuri Victorovich
Modified: 2026-04-06 18:55 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2026-04-06 17:34:56 UTC
Currently portlint prints many errors per file.

Instead portlint should just report one error for the whole WRKDIR:
> Please clean to remove the WRKDIR directory 'work'
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2026-04-06 18:36:05 UTC
It actually _does_ to this work `work`:

```
⇒  ls
Makefile	distinfo	files/		pkg-descr	pkg-message	work/
root@badlands:~/src/ports/xml2rfc|
⇒  !po
root@badlands:~/src/ports/xml2rfc|
⇒  portlint -C
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
FATAL: work: be sure to cleanup the working directory before committing the port.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
1 fatal error and 1 warning found.
```

However, for something like work-py311 it does not.  I suppose you're asking for the same to apply for FLAVOR'd WRKDIRs?
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2026-04-06 18:55:40 UTC
(In reply to Joe Marcus Clarke from comment #1)

Yes, it should use 'make -V WRKDIR'.

In case of flavored ports it should go through all possible WRKDIRs: 'make FLAVOR={flavor} -V WRKDIR'.