Created attachment 269507 [details] updates_to_signal-cli_and_libsignal This patch updates net-im/signal-cli to v0.14.2 and applies the necessary updates to its libsignal dependency (upgraded to v0.90.0). Reason for update: The current ports tree version (0.13.20) fails to communicate correctly with Signal's servers. Specifically, registering a new account phone number results in a 499 error when attempting to verify the TOTP code. Updating to 0.14.2 resolves this issue. Additional changes included in this patch: * libsignal: Removed the `boringssl_fips` dependency. This removal is intentional and reflects upstream changes. * signal-cli patch removal: Upstream has officially added `freebsd` as a cargo target OS. As a result, the FreeBSD-specific patch file that previously handled this has been updated to skip that part. * rc.d script: While I was at it, I improved the `signal_cli` rc.d script's understanding of the `signal-cli` user and its interaction with the `daemon` call. You can now use it with specific cmd opts like "--http" or "--socket" via rc.conf Testing Notes: * Tested and confirmed working properly using the `--http` flag on a headless server. * I did not explicitly test the new version with `--dbus-system` (the new name of the original default flag) as I am not running a desktop environment, but I have no reason to believe that behavior would be any different or broken.
I tossed this up at https://github.com/freebsd/freebsd-ports/compare/main...schmitmd:freebsd-ports:signal-cli_v0.14.2 as well, should anyone care to take a look. same stuff, just in github
I appreciate the patch and especially the updated `rc.d` file. However I want to keep libsignal at v0.87.5 to keep https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290820 building
Hmm.. I could drop it back down to 0.14.0..? that one works with libsignal v 0.87.4 (and presumably .5)..
Hey I confused you with a mikael, but you are not one and the same. I already have a PR open already for bumping to 0.14.1, without a rc.d patch: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=293378 (with a mikael) Sorry for the confusion, I really welcome the patches you sent! That PR got stalled because I rushed the bump to prevent people losing accounts, and did not due my due-diligence. It should be in working condition now. I am not sure what the conventional thing to do is here, as the rc.d update is really appreciated. I think I would like my PR to be as-is, and this to only include the rc.d update. That way this could also get merged independently if needed.
Fugu's a better moniker anyway (and my git username). Updated. Sorry for missing that bug, I guess I did a sub-par job of bugzilla searching. :/ Do you want to just steal my rc.d changes? I can drop you a patch with just that in it or you can copy pasta it on in for your own changeset. I don't mind, just happy to help.