Bug 294337 - net-mgmt/thanos: Build with '-tags slicelabels' to fix gRPC panics
Summary: net-mgmt/thanos: Build with '-tags slicelabels' to fix gRPC panics
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Älven
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-04-08 16:37 UTC by Magnus Kaiser
Modified: 2026-04-08 19:02 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (alven)
alven: merge-quarterly+


Attachments
makefile patch (725 bytes, patch)
2026-04-08 16:37 UTC, Magnus Kaiser
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Kaiser 2026-04-08 16:37:37 UTC
Created attachment 269509 [details]
makefile patch

Thanos in at least build version 0.41.0-1 causes panics once grpc calls to the sidecar or store component are made. This appears to be an issue known in upstream (https://github.com/thanos-io/thanos/issues/8543) but the fix requires the use of the `-tags slicelabels` go build flags. I've used the attached patch to build the port and now thanos appears stable.
Comment 1 Älven freebsd_committer freebsd_triage 2026-04-08 18:02:11 UTC
Thank you for reporting and proposing a fix :) I'm testing it now...
Comment 2 commit-hook freebsd_committer freebsd_triage 2026-04-08 18:37:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b21fae5132961c8b37bb83b5ddfebb77752f60cd

commit b21fae5132961c8b37bb83b5ddfebb77752f60cd
Author:     Magnus Kaiser <freebsd@4xoc.com>
AuthorDate: 2026-04-08 17:54:43 +0000
Commit:     Älven <alven@FreeBSD.org>
CommitDate: 2026-04-08 18:36:23 +0000

    net-mgmt/thanos: Build with '-tags slicelabels' to fix gRPC panics

    Thanos in at least build version 0.41.0-1 causes panics once gRPC
    calls to the sidecar or store component are made. This appears to be
    an issue known in upstream [0], but the fix requires the use of the
    `-tags slicelabels` Go build flags.

    [0] https://github.com/thanos-io/thanos/issues/8543

    PR:             294337
    Tested by:      Magnus Kaiser <freebsd@4xoc.com>
    Approved by:    db@, yuri@ (Mentors, implicit)
    MFH:            2026Q2

 net-mgmt/thanos/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2026-04-08 18:40:35 UTC
A commit in branch 2026Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3bb9c0e527a69f97f88e8f3d5ff02f4b3d122bf2

commit 3bb9c0e527a69f97f88e8f3d5ff02f4b3d122bf2
Author:     Magnus Kaiser <freebsd@4xoc.com>
AuthorDate: 2026-04-08 17:54:43 +0000
Commit:     Älven <alven@FreeBSD.org>
CommitDate: 2026-04-08 18:39:12 +0000

    net-mgmt/thanos: Build with '-tags slicelabels' to fix gRPC panics

    Thanos in at least build version 0.41.0-1 causes panics once gRPC
    calls to the sidecar or store component are made. This appears to be
    an issue known in upstream [0], but the fix requires the use of the
    `-tags slicelabels` Go build flags.

    [0] https://github.com/thanos-io/thanos/issues/8543

    PR:             294337
    Tested by:      Magnus Kaiser <freebsd@4xoc.com>
    Approved by:    db@, yuri@ (Mentors, implicit)
    MFH:            2026Q2

    (cherry picked from commit b21fae5132961c8b37bb83b5ddfebb77752f60cd)

 net-mgmt/thanos/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 4 Älven freebsd_committer freebsd_triage 2026-04-08 18:41:52 UTC
Thank you for helping me with one of my ports! :)
Comment 5 Magnus Kaiser 2026-04-08 19:02:28 UTC
And thank you for the fast upstream fix, much appreciated :)