Bug 294775 - pkgbase ${SRC}/release/release.sh WITHOUT_QUOTAS=YES: quotacheck.plist error
Summary: pkgbase ${SRC}/release/release.sh WITHOUT_QUOTAS=YES: quotacheck.plist error
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 16.0-CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Lexi Winter
URL: https://reviews.freebsd.org/D56635
Keywords:
Depends on:
Blocks:
 
Reported: 2026-04-25 09:22 UTC by Alastair Hogge
Modified: 2026-05-04 08:32 UTC (History)
2 users (show)

See Also:
ivy: mfc-stable15?
ivy: mfc-stable14-


Attachments
[PATCH] ${SRC}/packages/Makefile for SUBDIR.${MK_QUOTAS} (1.81 KB, patch)
2026-04-25 13:34 UTC, Alastair Hogge
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alastair Hogge 2026-04-25 09:22:52 UTC
On a 16-CURRENT-4602d45eb3b1 host, attempting build with WITHOUT_QUOTAS=YES in ${SRCCONF} results in the build failing:
> --- all_subdir_quotacheck ---
> make[7]: don't know how to make quotacheck.plist. Stop
> 
> make[7]: stopped making "all" in /usr/src/packages/quotacheck
> 
> make[6]: stopped making "clean all stagepackages" in /usr/src/packages
Comment 1 Alastair Hogge 2026-04-25 12:26:26 UTC
quotacheck in ${SRC}/packages/Makefile[1] might need to be constrained under a SUBDIR.${MK_QUOTAS} directive.

1: https://codeberg.org/FreeBSD/freebsd-src/src/branch/main/packages/Makefile#L64
Comment 2 Alastair Hogge 2026-04-25 13:34:12 UTC
Created attachment 270106 [details]
[PATCH] ${SRC}/packages/Makefile for SUBDIR.${MK_QUOTAS}

make: don't know how to make quotacheck.plist. Stop
make: stopped making "all" in /usr/src/packages/quotacheck
make: stopped making "clean all stagepackages" in /usr/src/packages

Move quotacheck to SUBDIR.${MK_QUOTAS} to reflect the ${SRCCONF} option
WITHOUT_QUOTAS, and sort the surrounding SUBDIR.* declarations.
Comment 3 Alastair Hogge 2026-04-25 13:35:00 UTC
Tested against 16-CURRENT-4602d45eb3b1 with/without WITHOUT_QUOTAS.
Comment 4 commit-hook freebsd_committer freebsd_triage 2026-04-27 05:47:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=221b1d4156a2bfe71a473e5abf6a739c063e60d8

commit 221b1d4156a2bfe71a473e5abf6a739c063e60d8
Author:     Lexi Winter <ivy@FreeBSD.org>
AuthorDate: 2026-04-27 05:45:48 +0000
Commit:     Lexi Winter <ivy@FreeBSD.org>
CommitDate: 2026-04-27 05:45:48 +0000

    packages: Don't build quotacheck if WITHOUT_QUOTAS=yes

    PR:     294775
    Fixes:  bb75b0d581f7 ("packages: Convert world to a subdir build")
    MFC after:      2 weeks
    Reported by:    Alastair Hogge <agh@riseup.net>
    Sponsored by:   https://www.patreon.com/bsdivy
    Differential Revision:  https://reviews.freebsd.org/D56635

 packages/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)