Bug 294983 - security/py-pyotp2289: Update the port to version 2.0.0
Summary: security/py-pyotp2289: Update the port to version 2.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yusuf Yaman
URL: https://codeberg.org/sgs/pyotp2289/sr...
Keywords:
Depends on:
Blocks:
 
Reported: 2026-05-03 17:06 UTC by Simeon Simeonov
Modified: 2026-05-03 20:24 UTC (History)
2 users (show)

See Also:
vvd: maintainer-feedback+


Attachments
diff (2.05 KB, patch)
2026-05-03 17:06 UTC, Simeon Simeonov
no flags Details | Diff
shar file (2.70 KB, text/plain)
2026-05-03 17:08 UTC, Simeon Simeonov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simeon Simeonov 2026-05-03 17:06:32 UTC
Created attachment 270386 [details]
diff

Triggered by https://portscout.freebsd.org/sgs@pichove.org.html, the port was updated to the latest upstream version.

The port passes all checks and portlint.

Attached both .diff and .shar files


Kind regards

Simeon Simeonov - author and maintainer
Comment 1 Simeon Simeonov 2026-05-03 17:08:25 UTC
Created attachment 270387 [details]
shar file
Comment 2 Yusuf Yaman freebsd_committer freebsd_triage 2026-05-03 18:53:54 UTC
Hi,

Thank you for your submission.

Regarding .shar files on Bugzilla, a quote from Porter's Handbook. Thank you for sharing both.

Previously it was possible to submit patches for new ports using a shar(1) file; this is no longer the case with the evolution of git(1). Committers no longer accept shar(1) files as their use is prone to mistake and does not add the relevant entry in the category’s Makefile.

I have tested the patch in Poudriere on 14.4-RELEASE-amd64-main-d80fc2ccfd50.

However, It seems now the port is missing two build dependencies, devel/py-setuptools and devel/py-wheel. I suspect this is caused by the USES change, I believe they were pulling wheel and setuptools automatically, now they required explicitly.

diff --git a/security/py-pyotp2289/Makefile b/security/py-pyotp2289/Makefile
index f377e8321530..3e9a477659a2 100644
--- a/security/py-pyotp2289/Makefile
+++ b/security/py-pyotp2289/Makefile
@@ -11,6 +11,9 @@ WWW=          https://codeberg.org/sgs/pyotp2289
 LICENSE=       BSD2CLAUSE
 LICENSE_FILE=  ${WRKSRC}/LICENSE

+BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}setuptools>=0:devel/py-setuptools@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}wheel>=0:devel/py-wheel@${PY_FLAVOR}
+
 USES=          python
 USE_PYTHON=    autoplist concurrent pep517 pytest

Otherwise, it seems OK including `make test` (19/19 passed).

Thanks.
Comment 3 commit-hook freebsd_committer freebsd_triage 2026-05-03 20:16:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0a6481d31740bf262e4bdd705121d8d8bcbc59b9

commit 0a6481d31740bf262e4bdd705121d8d8bcbc59b9
Author:     Simeon Simeonov <sgs@pichove.org>
AuthorDate: 2026-05-03 18:45:07 +0000
Commit:     Yusuf Yaman <nxjoseph@FreeBSD.org>
CommitDate: 2026-05-03 20:08:49 +0000

    security/py-pyotp2289: Update 1.2.1 => 2.0.0

    Changelog:
    https://codeberg.org/sgs/pyotp2289/src/tag/v2.0.0/CHANGELOG.md

    Commit log:
    https://codeberg.org/sgs/pyotp2289/compare/v1.2.1...v2.0.0

    Port changes:
    * Update WWW: github => codeberg.
    * Switch to pep517 from deprecated distutils.

    PR:             294983
    Reported by:    Simeon Simeonov <sgs@pichove.org> (maintainer)
    Approved by:    vvd (co-mentor)

 security/py-pyotp2289/Makefile                      | 10 ++++++----
 security/py-pyotp2289/distinfo                      |  4 ++--
 .../py-pyotp2289/files/patch-pyproject.toml (new)   | 21 +++++++++++++++++++++
 3 files changed, 29 insertions(+), 6 deletions(-)
Comment 4 Yusuf Yaman freebsd_committer freebsd_triage 2026-05-03 20:24:15 UTC
Committed, thanks.