* Backport upstream commit d9e81a9a8af7679733907418a340c50e9fec8023 * Remove dead mirror site * Add USES= pathfix Reference: https://github.com/metabrainz/libdiscid/commit/d9e81a9a8af7679733907418a340c50e9fec8023
Created attachment 271383 [details] Patch for libdiscid
Why add pathfix back in? I thought that was deprecated and handled automatically now.
(In reply to Jason E. Hale from comment #2) Once again a mat and bapt does something and later refuses to answer. https://cgit.freebsd.org/ports/commit/Mk/bsd.port.mk?id=42c7fa35dcb9fd63e338ef6ac1a7e8b5fe4ca173 https://lists.freebsd.org/archives/dev-commits-ports-main/2025-September/162646.html I (among others) want a build log that's accurate
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d5569f488c5eccfb28651f00a7dd73f51035e563 commit d5569f488c5eccfb28651f00a7dd73f51035e563 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2026-06-15 17:23:58 +0000 Commit: Jason E. Hale <jhale@FreeBSD.org> CommitDate: 2026-06-15 17:39:46 +0000 audio/libdiscid: Use HTTPS for MusicBrainz URLs Add upstream commit to use HTTPS for MusicBrainz URLs to prevent redirects and potential man-in-the-middle (MITM) attacks. Update MASTER_SITES. Co-authored-by: Jason E. Hale <jhale@FreeBSD.org> PR: 294986 audio/libdiscid/Makefile | 11 +++++++---- audio/libdiscid/distinfo | 4 +++- 2 files changed, 10 insertions(+), 5 deletions(-)
Committed with minor changes, thanks!
Thanks, There's no need to add += to PATCHFILES btw
(In reply to Daniel Engberg from comment #6) If there’s another patch that needs to be added, using += creates less churn and allows for a brief inline comment as to what the patch does.
(In reply to Jason E. Hale from comment #7) Add it in commit message instead of cluttering the Makefile? Fwiw, it's also the syntax PH suggests. https://docs.freebsd.org/en/books/porters-handbook/book/#porting-patchfiles
(In reply to Daniel Engberg from comment #8) A brief comment in the Makefile saves me having to do research months or years later. The PHB shows two patches on the same line which is not great for readability, but I imagine it was done this way to simplify the example.