Bug 295045 - devd: Use PF_LOCAL instead of PF_INET
Summary: devd: Use PF_LOCAL instead of PF_INET
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 16.0-CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Kyle Evans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-05-06 07:21 UTC by Marek Zarychta
Modified: 2026-06-13 06:50 UTC (History)
1 user (show)

See Also:
kevans: mfc-stable15+
kevans: mfc-stable14+

Attachments
0001-devd-Use-PF_LOCAL-instead-of-PF_INET.patch (865 bytes, patch)
2026-05-06 07:21 UTC, Marek Zarychta 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Zarychta 2026-05-06 07:21:36 UTC 
Created attachment 270450 [details]
0001-devd-Use-PF_LOCAL-instead-of-PF_INET.patch

While working on the review D56797, I found a flaw, or rather incompatibility, in devd(8) that prevents media checking when there is no INET support in the system. We can easily fix it by using PF_LOCAL.

The patch was tested on a system without INET support, and it fixes the issue.
Comment 1 commit-hook freebsd_committer freebsd_triage 2026-05-07 01:29:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=b2e4da0b53ad082768b8f6f83766e030fd00d02a

commit b2e4da0b53ad082768b8f6f83766e030fd00d02a
Author:     Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
AuthorDate: 2026-05-07 01:28:08 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2026-05-07 01:28:08 +0000

    devd: Use PF_LOCAL instead of PF_INET

    Avoid dependency on INET (IPv4) by using PF_LOCAL,
    allowing media check to work on systems without INET support.

    PR:             295045
    Reviewed by:    kevans
    MFC after:      1 week

 sbin/devd/devd.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 Kyle Evans freebsd_committer freebsd_triage 2026-05-07 01:31:27 UTC 
mine
Comment 3 commit-hook freebsd_committer freebsd_triage 2026-06-10 04:01:29 UTC 
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=87224fa6514063d6fc1505ec95498f50cf8802d8

commit 87224fa6514063d6fc1505ec95498f50cf8802d8
Author:     Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
AuthorDate: 2026-05-07 01:28:08 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2026-06-10 04:00:47 +0000

    devd: Use PF_LOCAL instead of PF_INET

    Avoid dependency on INET (IPv4) by using PF_LOCAL,
    allowing media check to work on systems without INET support.

    PR:             295045
    Reviewed by:    kevans

    (cherry picked from commit b2e4da0b53ad082768b8f6f83766e030fd00d02a)

 sbin/devd/devd.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2026-06-10 04:02:32 UTC 
A commit in branch stable/15 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=b575dac3e415ceee136ed77be25e04e3bfce73ce

commit b575dac3e415ceee136ed77be25e04e3bfce73ce
Author:     Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
AuthorDate: 2026-05-07 01:28:08 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2026-06-10 04:00:36 +0000

    devd: Use PF_LOCAL instead of PF_INET

    Avoid dependency on INET (IPv4) by using PF_LOCAL,
    allowing media check to work on systems without INET support.

    PR:             295045
    Reviewed by:    kevans

    (cherry picked from commit b2e4da0b53ad082768b8f6f83766e030fd00d02a)

 sbin/devd/devd.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Marek Zarychta 2026-06-13 06:50:27 UTC 
(In reply to Kyle Evans from comment #2)
Thank you very much for taking care of this!