Bug 295458 - mail/mailman3: delay cleanup of .orig files until after "make patch"
Summary: mail/mailman3: delay cleanup of .orig files until after "make patch"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Craig Leres
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-05-20 20:35 UTC by Craig Leres
Modified: 2026-05-21 16:37 UTC (History)
1 user (show)

See Also:
einar: maintainer-feedback+


Attachments
patch (1.54 KB, patch)
2026-05-20 20:36 UTC, Craig Leres
einar: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer freebsd_triage 2026-05-20 20:35:27 UTC
When I need to update a port patch, I use "make patch" followed by "make makepatch PATCHDIR=/tmp". By delaying clean up of .orig files until "build" they are available for patch update activity but are not included in the package.

While here, clean up minor portlint nits.
Comment 1 Craig Leres freebsd_committer freebsd_triage 2026-05-20 20:36:15 UTC
Created attachment 270966 [details]
patch
Comment 2 Einar Bjarni Halldórsson 2026-05-20 23:34:33 UTC
(In reply to Craig Leres from comment #1)

No objections from me
Comment 3 Craig Leres freebsd_committer freebsd_triage 2026-05-20 23:57:53 UTC
Could you please change maintainer-approval on the patch from '?' to '+'?
Comment 4 commit-hook freebsd_committer freebsd_triage 2026-05-21 16:11:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=09a36d388907f99f991e47769eee31ed81202ed4

commit 09a36d388907f99f991e47769eee31ed81202ed4
Author:     Craig Leres <leres@FreeBSD.org>
AuthorDate: 2026-05-21 16:10:39 +0000
Commit:     Craig Leres <leres@FreeBSD.org>
CommitDate: 2026-05-21 16:10:39 +0000

    mail/mailman3: Delay cleanup of .orig files until after "make patch"

    By delaying clean up of .orig files until "build" they are available
    for patch update activity but are not included in the package.

    While here, clean up minor portlint nits.

    PR:             295458
    Approved by:    einar (maintainer)

 mail/mailman3/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 5 Craig Leres freebsd_committer freebsd_triage 2026-05-21 16:37:38 UTC
Thanks for the quick approval!