Created attachment 271327 [details] The diff file The latest upstream version of fractgen is 3.0.11. Therefore, the port graphics/fractgen needs an update. This version provides build options enhancements, allowing flexible components configuration for the FreeBSD port. Particularly, it also allows to build the KDE version now (off by default). Fix: The updated diff file fractgen-3.0.11.diff is attached.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d2afd1be751b318e357ece962685bab1aaf0f97c commit d2afd1be751b318e357ece962685bab1aaf0f97c Author: Thomas Dreibholz <thomas.dreibholz@gmail.com> AuthorDate: 2026-06-04 19:29:13 +0000 Commit: Yusuf Yaman <nxjoseph@FreeBSD.org> CommitDate: 2026-06-06 11:24:48 +0000 graphics/fractgen: Update 3.0.8 => 3.0.11 Changelog: https://github.com/dreibh/fractgen/blob/fractgen-3.0.11/ChangeLog Commit log: https://github.com/dreibh/fractgen/compare/fractgen-3.0.8...fractgen-3.0.11 Port changes: - Revise USES. - Populate OPTIONS and add KDE option off by default. - Update pkg-descr. PR: 295702 Reported by: Thomas Dreibholz (maintainer) Approved by: osa, vvd (Mentors, implicit) graphics/fractgen/Makefile | 36 ++- graphics/fractgen/distinfo | 6 +- graphics/fractgen/pkg-descr | 13 +- graphics/fractgen/pkg-plist | 607 ++++++++++++++++++++++---------------------- 4 files changed, 349 insertions(+), 313 deletions(-)
Hi, Thank you for your submission. I have tested build in Poudriere on 14.4-RELEASE-amd64-main-eb44fd6267a8 and it seems OK (Tested KDE option too). Committed, thanks.
+FRACTGEN_KDE_LIB_DEPENDS= libKF6ConfigWidgets.so:x11-toolkits/kf6-kconfigwidgets \ FRACTGEN_KDE_USE= KDE=configwidgets + libKF6ColorScheme.so:x11-themes/kf6-kcolorscheme \ FRACTGEN_KDE_USE= KDE=colorscheme + libKF6ConfigGui.so:devel/kf6-kconfig \ + libKF6ConfigCore.so:devel/kf6-kconfig \ FRACTGEN_KDE_USE= KDE=config + libKF6GuiAddons.so:x11-toolkits/kf6-kguiaddons FRACTGEN_KDE_USE= KDE=guiaddons
2. Why names so long: +OPTIONS_DEFINE= FRACTGEN_CLI \ + FRACTGEN_KDE \ + FRACTGEN_QT \ Why not just: CLI, KDE, QT?
3. OPTIONS_DEFAULT= ${OPTIONS_DEFINE:NFRACTGEN_KDE} You have just 4 options, one of them is default (EXAMPLES) - use: OPTIONS_DEFAULT= CLI QT Look much simpler.
4. Wrong order: +%%EXAMPLES%%%%DATADIR%%/examples/zeta12.fsf +%%FRACTGEN_CLI%%bin/clifractgen DATADIR=share/fractgen After substitution correct order is: bin/clifractgen share/fractgen/examples/zeta12.fsf
Created attachment 271556 [details] 0001-graphics-fractgen-Improve-port.patch Hi Vladimir, Thank you for the improvements! Indeed, the Makefile seems to be simpler now. Can you confirm that the adjustments I did are right?
5. Default value of "EXAMPLES_DESC=Build and/or install examples" - why redefine it?
6. Correct order: %%EXAMPLES%%%%DATADIR%%/examples/zeta11.fsf %%EXAMPLES%%%%DATADIR%%/examples/zeta12.fsf %%DATADIR%%/fractgen_de.qm %%DATADIR%%/fractgen_nb.qm
(In reply to Vladimir Druzenko from comment #8) You're right, it means the same. diff --git a/graphics/fractgen/Makefile b/graphics/fractgen/Makefile index a73a27f31e14..435af7334eaa 100644 --- a/graphics/fractgen/Makefile +++ b/graphics/fractgen/Makefile @@ -20,7 +20,6 @@ OPTIONS_DEFAULT= CLI QT OPTIONS_SUB= yes CLI_DESC= Build the command-line version -EXAMPLES_DESC= Include example files KDE_DESC= Build the KDE version QT_DESC= Build the Qt version diff --git a/graphics/fractgen/pkg-plist b/graphics/fractgen/pkg-plist index 4e9a436b2b5b..07ba115afb50 100644 --- a/graphics/fractgen/pkg-plist +++ b/graphics/fractgen/pkg-plist @@ -6,8 +6,6 @@ %%CLI%%share/bash-completion/completions/clifractgen %%QT%%share/bash-completion/completions/fractgen %%KDE%%share/bash-completion/completions/kfractgen -%%DATADIR%%/fractgen_de.qm -%%DATADIR%%/fractgen_nb.qm %%EXAMPLES%%%%DATADIR%%/examples/alpha01.fsf %%EXAMPLES%%%%DATADIR%%/examples/alpha02.fsf %%EXAMPLES%%%%DATADIR%%/examples/alpha03.fsf @@ -300,6 +298,8 @@ %%EXAMPLES%%%%DATADIR%%/examples/zeta10.fsf %%EXAMPLES%%%%DATADIR%%/examples/zeta11.fsf %%EXAMPLES%%%%DATADIR%%/examples/zeta12.fsf +%%DATADIR%%/fractgen_de.qm +%%DATADIR%%/fractgen_nb.qm share/icons/hicolor/512x512/apps/fractgen.png %%CLI%%share/man/man1/clifractgen.1.gz %%QT%%share/man/man1/fractgen.1.gz How is it now?
Created attachment 271566 [details] v1 Check this patch.
Created attachment 271567 [details] v2