Bug 295877 - net/phpldapadmin: patches for php85
Summary: net/phpldapadmin: patches for php85
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-06-05 15:08 UTC by Krzysztof
Modified: 2026-06-19 07:39 UTC (History)
1 user (show)

See Also:
ports: maintainer-feedback+
vvd: merge-quarterly+

Attachments
update patch (3.55 KB, patch)
2026-06-05 15:08 UTC, Krzysztof 		ports: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof 2026-06-05 15:08:11 UTC 
Created attachment 271525 [details]
update patch

As I switched to php85 I have to add some patches to net/phpldapadmin to avoid warnings ora errors in browser. This small patch touches three files of PLA and PLA is working correctly with php85.

I've tested that these patches apply correctly. So I hope it will be committed soon :-)))
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2026-06-13 00:25:00 UTC 
Why not update to 2.x?
Comment 2 commit-hook freebsd_committer freebsd_triage 2026-06-13 00:50:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=90ebf10b5ad1e4d4efd72a8baee270c6a2737b08

commit 90ebf10b5ad1e4d4efd72a8baee270c6a2737b08
Author:     Krzysztof <ports@bsdserwis.com>
AuthorDate: 2026-06-13 00:47:47 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2026-06-13 00:49:23 +0000

    net/phpldapadmin: Add support for php85

    PR:             295877
    Sponsored by:   UNIS Labs

 net/phpldapadmin/Makefile                          |  2 +-
 .../files/patch-lib_PLAAttribute.php (new)         | 12 +++++++++
 .../files/patch-lib_functions.php (new)            | 22 +++++++++++++++
 net/phpldapadmin/files/patch-lib_xml2array.php     | 31 ++++++----------------
 4 files changed, 43 insertions(+), 24 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2026-06-13 00:54:35 UTC 
A commit in branch 2026Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e2ffecea5bd4d510508bbb77349822e5934f2143

commit e2ffecea5bd4d510508bbb77349822e5934f2143
Author:     Krzysztof <ports@bsdserwis.com>
AuthorDate: 2026-06-13 00:47:47 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2026-06-13 00:54:16 +0000

    net/phpldapadmin: Add support for php85

    PR:             295877
    Sponsored by:   UNIS Labs

    (cherry picked from commit 90ebf10b5ad1e4d4efd72a8baee270c6a2737b08)

 net/phpldapadmin/Makefile                          |  2 +-
 .../files/patch-lib_PLAAttribute.php (new)         | 12 +++++++++
 .../files/patch-lib_functions.php (new)            | 22 +++++++++++++++
 net/phpldapadmin/files/patch-lib_xml2array.php     | 31 ++++++----------------
 4 files changed, 43 insertions(+), 24 deletions(-)
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2026-06-13 00:55:18 UTC 
Thanks.
Comment 5 Krzysztof 2026-06-19 07:39:52 UTC 
(In reply to Vladimir Druzenko from comment #1)
First of all PLA 2.x is still not full "compatible" with PLA 1.x. As you can see there is some features which have to be developed - see https://github.com/leenooks/phpLDAPadmin#outstanding-items

PLA 2.x require npm and other dependencies. I've started net/phpldapadmin2 port but I have to test it - that all dependencies will be installed.