Created attachment 271572 [details] Patch update 1.1.1 games/lmarbles: Update to 1.1.1 and take mantainership - add USES= localbase - add option for NLS - data now stored in $HOME/.lmarbles - removed post-patch, no longer needed Build tested in poudriere 15.0-RELEASE-p9 amd64 Play tested on 15.0-RELEASE-p9
Updated in commit https://cgit.freebsd.org/ports/commit/?id=931610d8942dde50242f94a5331a1d0b9e2f1988.
Hello, First I wanna express that I'm sorry as I didn't searched for open PRs this time. I'm working on this port for about a month since version 1.1 and waiting that upstream fixed some stuff in 1.1.1. Also, I always take maintainership on unmaintained ports updates to be sure that possible problems are easely addressed. Before I'll transfer maintainership to you please take a look at my commit (link is above sent by vvd@) and see if any change is needed. Cheers Thanks vvd@ for letting me know.
(In reply to Nuno Teixeira from comment #2) No trouble, and apologies for the double effort. This is the one that was missing the man page from 1.1 release tarball. I've built and installed your commit, cleaner approach than mine. I'm a softie for games nostalgia, though not many active projects open for maintainership. Question for some clarification I had pulled this and just allowed the upstream makefile handle. Is pixmaps the prefered landing for desktop icons? - @${REINPLACE_CMD} -e 's|(datadir)/icons|(datadir)/pixmaps|; \ - s|(datadir)/pixmaps/lmarbles48.gif|(datadir)/pixmaps/lmarbles48.png|' \ - ${WRKSRC}/Makefile.in I'd be willing to keep up with maintining this one.
(In reply to dnpowers@me.com from comment #3) For what I see other ports doing, most install in pixmaps. At my PC, I see "Adwaita, AdwaitaLegacy, gnome, handhelds, hicolor, redglass, whiteglass" So I did respect old sed. Also I did removed fetching from SF/nemysisfreebsdp/${CATEGORIES}/:icons. Are this icons needed? version 1.1.1 ships with a desktop .png.
(In reply to Nuno Teixeira from comment #4) (...) ** > At my PC, I see "Adwaita, AdwaitaLegacy, gnome, handhelds, hicolor, redglass, > whiteglass" using icons
(In reply to Nuno Teixeira from comment #4) I did not see anything unusual during play testing, with regards to the removal of the extra icons fetching. They do not appear to be in use any longer. I'll stick with pixmaps location for the icons.
(In reply to dnpowers@me.com from comment #6) Ok, I will pass maintainer to you and close this PR. Be free to re-open it if needed. Also you can track https://sourceforge.net/p/lgames/bugs/116/ and see how upstream is doing. Thanks
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9713e05adcdda8af30adbae6d2376a59ad6467ed commit 9713e05adcdda8af30adbae6d2376a59ad6467ed Author: Nuno Teixeira <eduardo@FreeBSD.org> AuthorDate: 2026-06-14 18:51:10 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2026-06-14 18:51:10 +0000 games/lmarbles: Pass maintainership PR: 295905 games/lmarbles/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Committed. Thank you!