Bug 295923 - games/warzone2100: update to 4.7.0
Summary: games/warzone2100: update to 4.7.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL: https://github.com/Warzone2100/warzon...
Keywords:
Depends on:
Blocks:
 
Reported: 2026-06-07 16:31 UTC by Eric Camachat
Modified: 2026-06-11 14:12 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (amdmi3)


Attachments
update to 4.7.0 (6.29 KB, patch)
2026-06-07 16:31 UTC, Eric Camachat
no flags Details | Diff
update to 4.7.0 use EXTRACT_AFTER_ARGS (7.01 KB, patch)
2026-06-07 19:59 UTC, Eric Camachat
no flags Details | Diff
updated. (7.02 KB, patch)
2026-06-07 22:07 UTC, Eric Camachat
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Camachat 2026-06-07 16:31:43 UTC
Created attachment 271597 [details]
update to 4.7.0
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2026-06-07 18:00:55 UTC
Try this replacing LIB_DEPENDS with USES
LIB_DEPENDS= libturbojpeg.so:graphics/libjpeg-turbo --> USES= jpeg
https://docs.freebsd.org/en/books/porters-handbook/book/#uses-jpeg

While at it, you can replace the post-extract with EXTRACT_AFTER_ARGS and save some I/O, last line should be included.
https://cgit.freebsd.org/ports/tree/cad/lib3mf/Makefile#n23

If you have time you might want to look into what the post-patch section is trying to fix as CMAKE_ON= CMAKE_DISABLE_FIND_PACKAGE_Git is defined.

Finally, does it build in Poudriere and if so on what arch and version of FreeBSD?

Best regards,
Daniel
Comment 2 Eric Camachat 2026-06-07 19:59:50 UTC
Created attachment 271602 [details]
update to 4.7.0 use EXTRACT_AFTER_ARGS

(In reply to Daniel Engberg from comment #1)
Thanks for the information,

Here are my test results:

USES jpeg does not work, it requires libturbojpeg.a (graphics/libjpeg-turbo) not libjpeg.a (graphics/jpeg-turbo).

EXTRACT_AFTER_ARGS works.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2026-06-07 20:55:39 UTC
EXTRACT_AFTER_ARGS is missing --no-same-owner --no-same-permissions
It should also be placed above CMAKE_* variables :-)

CMAKE_ON= FETCHCONTENT_FULLY_DISCONNECTED
This can be removed as its redundant
https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n117

Looks good, thanks for having a look! :-)
Comment 4 Eric Camachat 2026-06-07 22:07:53 UTC
Created attachment 271603 [details]
updated.

(In reply to Daniel Engberg from comment #3)

Patch updated.
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2026-06-10 18:39:53 UTC
Daniel. please stop suggesting ill practices such as using EXTRACT_AFTER_ARGS. EXTRACT_AFTER_ARGS should never be used in individual ports because it violates extract abstraction, requires to duplicate default args in each port, silently breaks when default EXTRACT_AFTER_ARGS are changed, or when EXTRACT_CMD changes. Please double stop to suggest ill practices in others' ports, because maintainers would have to ask submitters to undo changes suggested by you, requiring extra work and unneeded frustration.

Eric, I've had warzone2100 update in the works, blocked on build failure caused by libturbojpeg, for which you've had the good solution I've cherry picked. Please test the port update from https://github.com/AMDmi3/freebsd-ports/.
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2026-06-10 19:17:38 UTC
(In reply to Dmitry Marakasov from comment #5)
..or please stop working against change? It's commonly accepted, reduces both extraction size and unnecessary I/O which also indirectly in many setups also will reduce RAM pressure as Poudriere uses tmpfs for WRKDIR. Please stop making up issues that don't exist, there's no "silent" breakage, the only breakage you would see is if you commit without testing which would occur either way.

Eric's patch is also the more consistent one as it keeps LIB_DEPENDS sorted
don't duplicate already defined CMAKE switches/args which also is noted in this PR.
Comment 7 Eric Camachat 2026-06-11 04:16:58 UTC
(In reply to Dmitry Marakasov from comment #5)
your repo works.
Comment 8 commit-hook freebsd_committer freebsd_triage 2026-06-11 12:54:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e2ed675236174f38e911dbf77cb7d08082fcfbe2

commit e2ed675236174f38e911dbf77cb7d08082fcfbe2
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2026-06-04 12:38:23 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2026-06-11 12:53:56 +0000

    games/warzone2100: update 4.6.3 → 4.7.0

    PR:             295923
    Submitted by:   eric@camachat.org (partial)
    Tested by:      eric@camachat.org

 games/warzone2100/Makefile                         | 11 +++++----
 games/warzone2100/distinfo                         |  6 ++---
 .../patch-lib_ivis__opengl_CMakeLists.txt (new)    | 15 +++++++++++++
 .../patch-lib_ivis__opengl_gfx_api_vk.cpp (new)    | 26 ++++++++++++++++++++++
 4 files changed, 49 insertions(+), 9 deletions(-)