Bug 295956 - net/eternalterminal: Fix crashes on FreeBSD
Summary: net/eternalterminal: Fix crashes on FreeBSD
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-06-09 04:04 UTC by ps
Modified: 2026-06-09 18:12 UTC (History)
3 users (show)

See Also:
vvd: maintainer-feedback? (eduardo)
eduardo: merge-quarterly+

Attachments
Upstream fixes from https://github.com/MisterTea/EternalTerminal (5.86 KB, patch)
2026-06-09 04:04 UTC, ps 		no flags Details | Diff
I had a missing file in the previous patch file (6.73 KB, patch)
2026-06-09 04:22 UTC, ps 		no flags Details | Diff
Fix crashes patches combined into a single patch (5.36 KB, patch)
2026-06-09 17:27 UTC, Nuno Teixeira 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ps 2026-06-09 04:04:00 UTC 
Created attachment 271642 [details]
Upstream fixes from https://github.com/MisterTea/EternalTerminal

These are fixes I landed upstream in etserver that causes it to crash on FreeBSD.  Given there hasn't been a release in a while, it would be good to get these resolved.
Comment 1 ps 2026-06-09 04:22:21 UTC 
Created attachment 271643 [details]
I had a missing file in the previous patch file
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2026-06-09 04:39:46 UTC 
Incorrect subject of this PR.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2026-06-09 11:36:41 UTC 
Hello,

Could you download patch with commit message?

I see that one patch is related to https://github.com/MisterTea/EternalTerminal/commit/c6650d9577f50317af197d1b1dd3e7b3cb2fc749

Is there more commits to backport?
Comment 4 John Baldwin freebsd_committer freebsd_triage 2026-06-09 14:26:00 UTC 
This seems to be the other commit: https://github.com/MisterTea/EternalTerminal/commit/a2d2e62d8d7b44a36a6e0b6bd0791d86a0708b9b
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2026-06-09 17:27:27 UTC 
Created attachment 271647 [details]
Fix crashes patches combined into a single patch

Added backports info to patch:

Add backports to fix etserver crashes on session end and transient errors.

Backport from:
- a2d2e62d8d7b ("terminal: Fix etserver crash on session end due to ECHILD (#748)")
- c6650d9577f5 ("base: Fix etserver crash on transient accept() errors (#756)")
Comment 6 commit-hook freebsd_committer freebsd_triage 2026-06-09 17:49:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=db15a1e6558a0fe310a8174ee2381ab8e98d4f60

commit db15a1e6558a0fe310a8174ee2381ab8e98d4f60
Author:     PS <ps@mu.org>
AuthorDate: 2026-06-09 17:31:36 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2026-06-09 17:48:33 +0000

    net/eternalterminal: Fix etserver crashes

    Add backports to fix etserver crashes on session end and transient errors.

    PR:             295956
    MFH:            2026Q2

 net/eternalterminal/Makefile                       |   2 +-
 .../files/patch-fix-crash-PR295956 (new)           | 113 +++++++++++++++++++++
 2 files changed, 114 insertions(+), 1 deletion(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2026-06-09 18:08:56 UTC 
A commit in branch 2026Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f227afeb3bcc53fd49cda480d604fe3a1bef5d0c

commit f227afeb3bcc53fd49cda480d604fe3a1bef5d0c
Author:     PS <ps@mu.org>
AuthorDate: 2026-06-09 17:31:36 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2026-06-09 17:51:04 +0000

    net/eternalterminal: Fix etserver crashes

    Add backports to fix etserver crashes on session end and transient errors.

    PR:             295956
    MFH:            2026Q2
    (cherry picked from commit db15a1e6558a0fe310a8174ee2381ab8e98d4f60)

 net/eternalterminal/Makefile                       |   2 +-
 .../files/patch-fix-crash-PR295956 (new)           | 113 +++++++++++++++++++++
 2 files changed, 114 insertions(+), 1 deletion(-)
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2026-06-09 18:12:17 UTC 
Committed, thanks!