Bug 296443 - databases/mysql97-server: needs a couple of patches
Summary: databases/mysql97-server: needs a couple of patches
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-07-02 10:19 UTC by Trond Endrestøl
Modified: 2026-07-19 09:16 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (joneum)


Attachments
Patch for components/mysqlbackup/backup_page_tracker.cc adding #include <cstdlib>. (4.52 KB, patch)
2026-07-02 10:19 UTC, Trond Endrestøl
no flags Details | Diff
Patch for router/src/harness/src/stdx/filesystem.cc adding #include <cstdlib> (619 bytes, patch)
2026-07-02 10:20 UTC, Trond Endrestøl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2026-07-02 10:19:44 UTC
Created attachment 272366 [details]
Patch for components/mysqlbackup/backup_page_tracker.cc adding #include <cstdlib>.

One bug:

--- components/mysqlbackup/CMakeFiles/component_mysqlbackup.dir/all ---
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/components/mysqlbackup/backup_page_tracker.cc:67:5: error: use of undeclared identifier 'free'; did you mean 's_mysql_log_builtins_string::free'?
   67 |     free(m_changed_pages_file);
      |     ^~~~
      |     s_mysql_log_builtins_string::free
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/include/mysql/components/services/log_builtins.h:696:22: note: 's_mysql_log_builtins_string::free' declared here
  696 | DECLARE_METHOD(void, free, (void *ptr));
      |                      ^
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/components/mysqlbackup/backup_page_tracker.cc:67:5: error: invalid use of member 'free' in static member function
   67 |     free(m_changed_pages_file);
      |     ^~~~
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/components/mysqlbackup/backup_page_tracker.cc:76:5: error: use of undeclared identifier 'free'; did you mean 's_mysql_log_builtins_string::free'?
   76 |     free(m_changed_pages_file);
      |     ^~~~
      |     s_mysql_log_builtins_string::free
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/include/mysql/components/services/log_builtins.h:696:22: note: 's_mysql_log_builtins_string::free' declared here
  696 | DECLARE_METHOD(void, free, (void *ptr));
      |                      ^
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/components/mysqlbackup/backup_page_tracker.cc:76:5: error: invalid use of member 'free' in static member function
   76 |     free(m_changed_pages_file);
      |     ^~~~
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/components/mysqlbackup/backup_page_tracker.cc:352:34: error: use of undeclared identifier 'malloc'; did you mean 's_mysql_log_builtins_string::malloc'?
  352 |   m_changed_pages_buf = (uchar *)malloc(CHANGED_PAGES_BUFFER_SIZE);
      |                                  ^~~~~~
      |                                  s_mysql_log_builtins_string::malloc
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/include/mysql/components/services/log_builtins.h:691:24: note: 's_mysql_log_builtins_string::malloc' declared here
  691 | DECLARE_METHOD(void *, malloc, (size_t len));
      |                        ^
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/components/mysqlbackup/backup_page_tracker.cc:352:34: error: invalid use of member 'malloc' in static member function
  352 |   m_changed_pages_buf = (uchar *)malloc(CHANGED_PAGES_BUFFER_SIZE);
      |                                  ^~~~~~
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/components/mysqlbackup/backup_page_tracker.cc:362:3: error: use of undeclared identifier 'free'; did you mean 's_mysql_log_builtins_string::free'?
  362 |   free(m_changed_pages_buf);
      |   ^~~~
      |   s_mysql_log_builtins_string::free
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/include/mysql/components/services/log_builtins.h:696:22: note: 's_mysql_log_builtins_string::free' declared here
  696 | DECLARE_METHOD(void, free, (void *ptr));
      |                      ^
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/components/mysqlbackup/backup_page_tracker.cc:362:3: error: invalid use of member 'free' in static member function
  362 |   free(m_changed_pages_buf);
      |   ^~~~
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/components/mysqlbackup/backup_page_tracker.cc:416:3: error: use of undeclared identifier 'free'; did you mean 's_mysql_log_builtins_string::free'?
  416 |   free(m_changed_pages_file);
      |   ^~~~
      |   s_mysql_log_builtins_string::free
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/include/mysql/components/services/log_builtins.h:696:22: note: 's_mysql_log_builtins_string::free' declared here
  696 | DECLARE_METHOD(void, free, (void *ptr));
      |                      ^
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/components/mysqlbackup/backup_page_tracker.cc:416:3: error: invalid use of member 'free' in static member function
  416 |   free(m_changed_pages_file);
      |   ^~~~
10 errors generated.
*** [components/mysqlbackup/CMakeFiles/component_mysqlbackup.dir/backup_page_tracker.cc.o] Error code 1

The other bug:

--- router/src/harness/src/CMakeFiles/harness_stdx.dir/stdx/filesystem.cc.o ---
/construction/xports/databases/mysql97-server/work/mysql-9.7.1/router/src/harness/src/stdx/filesystem.cc:120:18: error: use of undeclared identifier 'getenv'
  120 |     auto *path = getenv(envvar);
      |                  ^~~~~~
1 error generated.
Comment 1 Trond Endrestøl 2026-07-02 10:20:26 UTC
Created attachment 272367 [details]
Patch for router/src/harness/src/stdx/filesystem.cc adding #include <cstdlib>
Comment 2 commit-hook freebsd_committer freebsd_triage 2026-07-19 09:14:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=95fe3eb1515e855835a42dc18dbaf384b3051603

commit 95fe3eb1515e855835a42dc18dbaf384b3051603
Author:     Jochen Neumeister <joneum@FreeBSD.org>
AuthorDate: 2026-07-19 09:08:07 +0000
Commit:     Jochen Neumeister <joneum@FreeBSD.org>
CommitDate: 2026-07-19 09:13:11 +0000

    databases/mysql97: Fix build with llvm 21, directory ownership and cleanup

    - Add upstream patches for missing #include <type_traits> and <cstdlib>,
      fixing the build with clang/libc++ 21 [1] [2]
    - Register MY_SECDIR and MY_TMPDIR with mysql:mysql 0750 in pkg-plist,
      so mysqld no longer fails to start after package upgrades reset the
      ownership to root [3]
    - Fix CONFLICTS_INSTALL pattern in the client not matching
      mysql80-client
      and align it with the wildcard style used by the server
    - Update pkg-message for 9.x: mysql_upgrade no longer exists, the server
      performs upgrade tasks itself; fix version reference and quoting
    - Drop duplicate -DWITH_LZ4=system, remove a stale line continuation,
      whitespace fixes
    - Rename patch-sql_server_component_mysql__file__imp.cc to follow the
      patch naming convention

    PR:             296439 [1], 296443 [2], 296758 [3]
    Reported by:    Trond Endrestøl [1] [2], Alexander Ushakov [3]

    sponsored by:   Netzkommune GmbH

 databases/mysql97-client/Makefile                             |  9 ++++-----
 databases/mysql97-server/Makefile                             |  9 ++++-----
 ...atch-components_mysqlbackup_backup__page__tracker.cc (new) | 10 ++++++++++
 .../files/patch-libs_mysql_gtid_tag__plain.h (new)            | 10 ++++++++++
 .../patch-router_src_harness_src_stdx_filesystem.cc (new)     | 10 ++++++++++
 ...imp.cc => patch-sql_server__component_mysql__file__imp.cc} |  0
 databases/mysql97-server/files/pkg-message.in                 | 11 ++++-------
 databases/mysql97-server/pkg-plist                            |  7 +++----
 8 files changed, 45 insertions(+), 21 deletions(-)