Bug 296523 - archivers/php-zstd, brotli, lz4: restore build with php86 (+ version bumps)
Summary: archivers/php-zstd, brotli, lz4: restore build with php86 (+ version bumps)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on: 296524
Blocks:
  Show dependency treegraph
 
Reported: 2026-07-04 20:36 UTC by Paavo-Einari Kaipila
Modified: 2026-07-12 17:28 UTC (History)
1 user (show)

See Also:
pkaipila: maintainer-feedback+


Attachments
0001-archivers-php-zstd-update-0.16.0-0.17.0.patch (3.25 KB, patch)
2026-07-04 20:37 UTC, Paavo-Einari Kaipila
no flags Details | Diff
0002-archivers-php-brotli-update-0.19.0-0.20.0.patch (3.39 KB, patch)
2026-07-04 20:37 UTC, Paavo-Einari Kaipila
no flags Details | Diff
0003-archivers-php-lz4-restore-build-with-php86.patch (693 bytes, patch)
2026-07-04 20:38 UTC, Paavo-Einari Kaipila
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paavo-Einari Kaipila 2026-07-04 20:36:45 UTC
Bofh marked these incompatible with php86 in 63b6120db0b8290c6b7d0b91d16c94bfe617ebfe.

I've upstreamed php86 fixes for zstd and brotli about a month ago and those fixes have already landed in our tree in commits 9f79d999cc78f4ad5eba8c5cd534a3c85ea0ecf2 and e5a35b56c2236596c728276135e5d07ee8449b10. LZ4 doesn't need any fixing.
https://github.com/kjdev/php-ext-brotli/pull/88
https://github.com/kjdev/php-ext-zstd/pull/97

All of these build and work just fine with php86 as long as apcu option is disabled, because apcu needs patching. I'll create a separate PR for that, which will likely timeout.

Zstd and brotli patches also contain regular version bumps released few days ago.
Comment 1 Paavo-Einari Kaipila 2026-07-04 20:37:16 UTC
Created attachment 272494 [details]
0001-archivers-php-zstd-update-0.16.0-0.17.0.patch
Comment 2 Paavo-Einari Kaipila 2026-07-04 20:37:44 UTC
Created attachment 272495 [details]
0002-archivers-php-brotli-update-0.19.0-0.20.0.patch
Comment 3 Paavo-Einari Kaipila 2026-07-04 20:38:12 UTC
Created attachment 272496 [details]
0003-archivers-php-lz4-restore-build-with-php86.patch
Comment 4 Paavo-Einari Kaipila 2026-07-04 21:03:53 UTC
apcu fix available in bug #296524
Comment 5 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2026-07-04 21:08:31 UTC
Send a direct mail to the APCu. It will get landed sooner than timeout.
Comment 6 Paavo-Einari Kaipila 2026-07-04 21:18:54 UTC
(In reply to Muhammad Moinur Rahman from comment #5)

Same fixes have been applied there already
https://github.com/krakjoe/apcu/commit/95f9ab828f95c6ca5877e584ead109189d0cec61
https://github.com/krakjoe/apcu/commit/d29e907791502af89a7996930f8dce5fd8efe4a1
Comment 7 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2026-07-05 12:44:27 UTC
(In reply to Paavo-Einari Kaipila from comment #6)
I meant the maintainer of APCu. Rather than bug reports send a mail. It will get landed faster.
Comment 8 Paavo-Einari Kaipila 2026-07-05 18:29:07 UTC
(In reply to Muhammad Moinur Rahman from comment #7)

email sent about bug #296524 and bug #296539
Comment 9 commit-hook freebsd_committer freebsd_triage 2026-07-12 17:25:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c862506f393f1e6d8e0e1c4b796c4a96a78328da

commit c862506f393f1e6d8e0e1c4b796c4a96a78328da
Author:     Paavo-Einari Kaipila <pkaipila@gmail.com>
AuthorDate: 2026-07-04 20:14:23 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2026-07-12 17:24:46 +0000

    archivers/php-zstd: Update version 0.16.0=>0.17.0

    Changelog:
    https://github.com/kjdev/php-ext-zstd/releases/tag/0.17.0

    Commit log:
    https://github.com/kjdev/php-ext-zstd/compare/0.16.0...0.17.0

    remove config.m4 patch, which has been upstreamed
    undo 63b6120db0b8290c6b7d0b91d16c94bfe617ebfe

    PR:             296523
    Approved by:    submitter is maintainer

 archivers/php-zstd/Makefile                     |  3 +-
 archivers/php-zstd/distinfo                     |  6 ++--
 archivers/php-zstd/files/patch-config.m4 (gone) | 38 -------------------------
 3 files changed, 4 insertions(+), 43 deletions(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2026-07-12 17:25:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1678d8941811e083e2ab8b0e3507f95f9c175af8

commit 1678d8941811e083e2ab8b0e3507f95f9c175af8
Author:     Paavo-Einari Kaipila <pkaipila@gmail.com>
AuthorDate: 2026-07-04 20:17:04 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2026-07-12 17:24:46 +0000

    archivers/php-brotli: Update version 0.19.0=>0.20.0

    Changelog:
    https://github.com/kjdev/php-ext-brotli/releases/tag/0.20.0

    Commit log:
    https://github.com/kjdev/php-ext-brotli/compare/0.19.0...0.20.0

    remove config.m4 patch, which has been upstreamed
    undo 63b6120db0b8290c6b7d0b91d16c94bfe617ebfe

    PR:             296523
    Approved by:    submitter is maintainer

 archivers/php-brotli/Makefile                     |  3 +-
 archivers/php-brotli/distinfo                     |  6 ++--
 archivers/php-brotli/files/patch-config.m4 (gone) | 37 -----------------------
 3 files changed, 4 insertions(+), 42 deletions(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2026-07-12 17:25:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=376814557776218c4b1cccb9f030a7d7a0d2ecfe

commit 376814557776218c4b1cccb9f030a7d7a0d2ecfe
Author:     Paavo-Einari Kaipila <pkaipila@gmail.com>
AuthorDate: 2026-07-12 13:45:51 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2026-07-12 17:24:45 +0000

    archivers/php-lz4: Restore build with php86

    PR:             296523
    Approved by:    submitter is maintainer
    Tested by:      bofh

 archivers/php-lz4/Makefile | 1 -
 1 file changed, 1 deletion(-)
Comment 12 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2026-07-12 17:28:05 UTC
Send a mail to the maintainer of pecl-zstd explaining that you two are maintaining redundant ports and that should be removed.