Bug 296694 - databases/duckdb: incorrect testing in LIB_DEPENDS pulls all optional dependencies even if extension is not not asked for or broken
Summary: databases/duckdb: incorrect testing in LIB_DEPENDS pulls all optional depende...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-07-11 13:26 UTC by Bruno Damour
Modified: 2026-08-01 13:31 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
patch against current ports tree (882 bytes, patch)
2026-08-01 13:31 UTC, Bruno Damour
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Damour 2026-07-11 13:26:58 UTC
In the loop over out of tree extensions (GH_TUPLE) used for checking which LIB_DEPENDS to add, an incorrect testing leads to always pull dependencies, notably aws-sdk-cpp, which in turns pulls a whole bunch of unneeded dependencies

in current port we have 
LIB_DEPENDS+= ${PORT_OPTIONS:M${opt}:?${${opt}_LIB_DEPENDS}:}
which always tests true 

I changed it to :
LIB_DEPENDS+= ${"${PORT_OPTIONS:M${opt}}" != "":?${${opt}_LIB_DEPENDS}:}
which actually skips unneeded dependencies (when opt is not not in PORT_OPTIONS)
Comment 1 Bruno Damour 2026-08-01 13:31:12 UTC
Created attachment 273382 [details]
patch against current ports tree

Attached a patch which makes a revision with fixed syntax