Bug 297212 - games/freeciv21: Update 3.1.1 => 3.1.2
Summary: games/freeciv21: Update 3.1.1 => 3.1.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Tagato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-07-31 17:58 UTC by Tobias Rehbein
Modified: 2026-08-06 14:22 UTC (History)
1 user (show)

See Also:

Attachments
Patch to update games/freeciv21 to v3.1.2 (1.32 KB, patch)
2026-07-31 17:58 UTC, Tobias Rehbein 		tobias.rehbein: maintainer-approval+
Details | Diff
Patch to update games/freeciv21 to v3.1.2; Revision 2 (1.81 KB, patch)
2026-08-03 20:51 UTC, Tobias Rehbein 		tobias.rehbein: maintainer-approval+
Details | Diff
Patch to update games/freeciv21 to v3.1.2; Revision 3 (1.88 KB, patch)
2026-08-05 21:11 UTC, Tobias Rehbein 		tobias.rehbein: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Rehbein 2026-07-31 17:58:34 UTC 
Created attachment 273366 [details]
Patch to update games/freeciv21 to v3.1.2

Changelog: https://github.com/longturn/freeciv21/releases/tag/v3.1.2

QA:
- poudriere testport (15.1 amd64): ok
- portlint -A: looks fine
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2026-08-03 00:29:40 UTC 
(In reply to Tobias Rehbein from comment #0)

Hi Tobias, thanks for an update to the port.

One question:
- Is there a compelling reason to use the custom variable FC21_VERSION?
  I think a combination of standard variables (DISTVERSIONPREFIX and DISTVERSION) should be enough.
Comment 2 Tobias Rehbein 2026-08-03 20:51:13 UTC 
Created attachment 273422 [details]
Patch to update games/freeciv21 to v3.1.2; Revision 2
Comment 3 Tobias Rehbein 2026-08-03 20:52:46 UTC 
(In reply to Hiroki Tagato from comment #1)

FC21_VERSION is a leftover from a time, when Freeciv21 used a non-standard versioning scheme. In the meantime the versioning scheme was changed and I guess you are right. Please take a look at the updated patch.
Comment 4 Hiroki Tagato freebsd_committer freebsd_triage 2026-08-04 02:42:58 UTC 
(In reply to Tobias Rehbein from comment #3)

Thanks for an update.

- MASTER_SITES
  FC21_VERSION still remains. Replace it with DISTVERSIONFULL.
- DISTNAME
  ${DISTVERSIONPREFIX}${DISTVERSION} can be replaced with ${DISTVERSIONFULL} for short.

The rest of the port looks good to me.
Comment 5 Tobias Rehbein 2026-08-05 21:11:24 UTC 
Created attachment 273493 [details]
Patch to update games/freeciv21 to v3.1.2; Revision 3

I updated the patch. Thanks for your advise.
Comment 6 commit-hook freebsd_committer freebsd_triage 2026-08-06 14:21:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=66168c364250bb2d978740f89aa046befc65547a

commit 66168c364250bb2d978740f89aa046befc65547a
Author:     Tobias Rehbein <tobias.rehbein@web.de>
AuthorDate: 2026-07-31 17:51:59 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2026-08-06 14:19:21 +0000

    games/freeciv21: Update 3.1.1 => 3.1.2

    While here, drop the custom variable FC21_VERSION and use standard
    variables instead.

    Changelog: https://github.com/longturn/freeciv21/releases/tag/v3.1.2

    PR:             297212
    Reported by:    Tobias Rehbein <tobias.rehbein@web.de> (maintainer)

 games/freeciv21/Makefile | 9 ++++-----
 games/freeciv21/distinfo | 6 +++---
 2 files changed, 7 insertions(+), 8 deletions(-)
Comment 7 Hiroki Tagato freebsd_committer freebsd_triage 2026-08-06 14:22:27 UTC 
Committed, thanks!