Bug 297275 - textproc/xlnt: fix xlnt.pc
Summary: textproc/xlnt: fix xlnt.pc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL: https://github.com/tfussell/xlnt/pull...
Keywords:
Depends on:
Blocks:
 
Reported: 2026-08-04 15:35 UTC by Thierry Thomas
Modified: 2026-08-04 19:34 UTC (History)
1 user (show)

See Also:
yuri: maintainer-feedback+


Attachments
Fix xlnt.pc (1.60 KB, patch)
2026-08-04 15:35 UTC, Thierry Thomas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2026-08-04 15:35:57 UTC
Created attachment 273449 [details]
Fix xlnt.pc

Without this patch, xlnt.pc is generated with the following lines:

includedir=include
libdir=lib

and when a program uses it with pkg-config, it returns -Iinclude -Llib
which of course is invalid.

The proposed patch adds the missing prefix, and now pkg-config --libs xlnt returns "-L/usr/local/lib -lxlnt" and pkg-config --cflags xlnt returns "-I/usr/local/include" for my case with e.g. $PREFIX=/usr/local.

PR submitted upstream: see https://github.com/tfussell/xlnt/pull/765
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2026-08-04 15:46:38 UTC
Thanks for the patch!
LGTM.
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2026-08-04 17:34:49 UTC
Committed, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2026-08-04 17:35:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=86bd6000e673f2ad01ef9d8357699e507b251587

commit 86bd6000e673f2ad01ef9d8357699e507b251587
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2026-08-04 15:09:59 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2026-08-04 17:33:19 +0000

    textproc/xlnt: fix xlnt.pc

    The corresponding PR has been submitted upstream: see
    https://github.com/tfussell/xlnt/pull/765

    PR:             297275
    Approved by:    yuri (maintainer)

 textproc/xlnt/Makefile                                |  1 +
 textproc/xlnt/files/patch-source_CMakeLists.txt (new) | 13 +++++++++++++
 2 files changed, 14 insertions(+)
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2026-08-04 19:34:36 UTC
Yuri,

I received a comment at
https://github.com/tfussell/xlnt/pull/765#issuecomment-5183294594

They say that the repo tfussell/xlnt is unmaintained, and that there is an active fork at
https://github.com/xlnt-community/xlnt

Maybe you should modify the port to switch to this one?