Bug 297568 - net/mosquitto: Rework port
Summary: net/mosquitto: Rework port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-08-16 03:13 UTC by Daniel Engberg
Modified: 2026-08-20 19:20 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (leres)


Attachments
Patch for mosquitto (2.64 KB, patch)
2026-08-16 03:13 UTC, Daniel Engberg
leres: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2026-08-16 03:13:02 UTC
Created attachment 273807 [details]
Patch for mosquitto

* Unbundle uthash as recommended by Porters Handbook [1]
* Unbundle (lib)websockets as recommended by Porters Handbook [1]
* Make (lib)websockets mandatory, this is default in all major distros
* Use sqlite helper [2]
* Prefer libedit as upstream provides no way of selecting either libedit or readline and it'll try to find libedit first
* Remove hack for adding path(s) to localbase, use helper instead [3]
* Disable WITH_HTTP_API as port will otherwise pick up libmicrohttpd in unclean environments
* Remove REINPLACE_CMD for CMakeLists.txt files as it does nothing

1: https://docs.freebsd.org/en/books/porters-handbook/book/#bundled-libs
2: https://docs.freebsd.org/en/books/porters-handbook/book/#uses-sqlite
3: https://docs.freebsd.org/en/books/porters-handbook/book/#uses-localbase

Poudriere testport ok on 14.4 (amd64) and 15.1 (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2026-08-16 03:19:13 UTC
..and I forgot,

* Remove hardcoded path for cjson
Comment 2 Craig Leres freebsd_committer freebsd_triage 2026-08-19 16:30:07 UTC
Comment on attachment 273807 [details]
Patch for mosquitto

Tests ok for me.
Comment 3 commit-hook freebsd_committer freebsd_triage 2026-08-20 19:19:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ebf4c5615678cdb2e97640039cbae2e7a2e2af0f

commit ebf4c5615678cdb2e97640039cbae2e7a2e2af0f
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2026-08-19 20:49:00 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2026-08-20 19:18:18 +0000

    net/mosquitto: Rework port

    * Unbundle uthash as recommended by Porters Handbook
    * Unbundle (lib)websockets as recommended by Porters Handbook
    * Make (lib)websockets mandatory, default in all major distros
    * Use sqlite helper
    * Prefer libedit as upstream provides no way of selecting either libedit
      or readline and it'll try to find libedit first
    * Remove hack for adding path(s) to localbase, use helper instead
    * Disable WITH_HTTP_API as port will otherwise pick up libmicrohttpd
      in unclean environments
    * Remove REINPLACE_CMD for CMakeLists.txt files as it does nothing
    * Remove hardcoded cjson path

    PR:             297568
    Tested by:      leres (maintainer)

 net/mosquitto/Makefile                          | 44 +++++++++----------------
 net/mosquitto/files/patch-CMakeLists.txt (gone) | 12 -------
 2 files changed, 15 insertions(+), 41 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2026-08-20 19:20:36 UTC
Committed, thanks