Bug 298007 - databases/sqlitebrowser: Switch bundled libraries to ports
Summary: databases/sqlitebrowser: Switch bundled libraries to ports
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kousuke Kannagi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-08-28 04:16 UTC by Kousuke Kannagi
Modified: 2026-09-01 10:40 UTC (History)
3 users (show)

See Also:
mce: maintainer-feedback? (osa)
fluffy: maintainer-feedback+

Attachments
Switch bundled libraries to ports (4.23 KB, patch)
2026-08-28 04:16 UTC, Kousuke Kannagi 		mce: maintainer-approval+
Details | Diff
Switch bundled libraries to ports (4.42 KB, patch)
2026-08-28 11:31 UTC, Kousuke Kannagi 		mce: maintainer-approval+
Details | Diff
Switch bundled libraries to ports (3.41 KB, patch)
2026-09-01 08:36 UTC, Kousuke Kannagi 		mce: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kousuke Kannagi freebsd_committer freebsd_triage 2026-08-28 04:16:37 UTC 
Created attachment 274197 [details]
Switch bundled libraries to ports

Fix build with cmake 4.
Comment 1 Kousuke Kannagi freebsd_committer freebsd_triage 2026-08-28 11:31:47 UTC 
Created attachment 274210 [details]
Switch bundled libraries to ports

Enable unit tests.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2026-08-29 10:56:37 UTC 
CMAKE_ARGS --> Use CMAKE_ON and CMAKE_OFF instead?
https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake
Comment 3 Kousuke Kannagi freebsd_committer freebsd_triage 2026-09-01 08:36:55 UTC 
Created attachment 274328 [details]
Switch bundled libraries to ports

Add SQLCIPHER option.
Switch from patchfiles to CMAKE_ARGS.
Comment 4 Dima Panov freebsd_committer freebsd_triage 2026-09-01 10:15:56 UTC 
LGTM
Comment 5 commit-hook freebsd_committer freebsd_triage 2026-09-01 10:38:21 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=43f38b2f50cc3f37c74819ef79af7e5e841057cd

commit 43f38b2f50cc3f37c74819ef79af7e5e841057cd
Author:     Kousuke Kannagi <mce@FreeBSD.org>
AuthorDate: 2026-09-01 08:27:09 +0000
Commit:     Kousuke Kannagi <mce@FreeBSD.org>
CommitDate: 2026-09-01 10:36:07 +0000

    databases/sqlitebrowser: Switch bundled libraries to ports

    Enable unit tests.
    Fix build with cmake 4.
    Add SQLCIPHER option.

    PR:             298007
    Approved by:    fluffy (mentor)

 databases/sqlitebrowser/Makefile                   | 25 ++++++++++++++++++----
 .../files/extra-patch-src_SqlUiLexer.cpp (new)     | 11 ++++++++++
 .../files/patch-libs_qhexedit_CMakeLists.txt (new) |  8 +++++++
 3 files changed, 40 insertions(+), 4 deletions(-)
Comment 6 Kousuke Kannagi freebsd_committer freebsd_triage 2026-09-01 10:40:36 UTC 
Thank you.