Bug 32601 - strange behaviour of distfiles survey software
Summary: strange behaviour of distfiles survey software
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bill Fenner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-12-08 13:10 UTC by edwin
Modified: 2001-12-18 21:40 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description edwin 2001-12-08 13:10:07 UTC
According to the url, the fetch failed. But... If you try to fetch
it, it does it without problems.

The ftp-server the software is on automaticly places you in /pub.
The software checks one directory each. The first "cd pub" fails.
The first check should be "cd /pub", the second should be "cd X11"

Fix: 

The first check should be "cd /pub", the second should be "cd X11".
How-To-Repeat: 
See URL and output of make in games/xvmines
Comment 1 Pete Fritchman freebsd_committer freebsd_triage 2001-12-08 14:01:24 UTC
Responsible Changed
From-To: freebsd-ports->fenner

Over to maintainer
Comment 2 Bill Fenner freebsd_committer freebsd_triage 2001-12-08 18:45:04 UTC
State Changed
From-To: open->closed

The distfile survey follows RFC 1738's definition of an FTP URL. 
If you want the first CWD to be "/pub", then the URL must 
start /%2fpub/... . 

The distfile survey also tries to mirror fetch(1)'s behavior. 
Unfortunately, fetch(1) got broken 16 months ago to make this 
a valid URL.
Comment 3 edwin 2001-12-09 23:56:16 UTC
On Sat, Dec 08, 2001 at 10:52:36AM -0800, fenner@FreeBSD.org wrote:
> Synopsis: strange behaviour of distfiles survey software
> 
> State-Changed-From-To: open->closed
> State-Changed-By: fenner
> State-Changed-When: Sat Dec 8 10:45:04 PST 2001
> State-Changed-Why: 
> The distfile survey follows RFC 1738's definition of an FTP URL.
> If you want the first CWD to be "/pub", then the URL must
> start /%2fpub/... .
> 
> The distfile survey also tries to mirror fetch(1)'s behavior.
> Unfortunately, fetch(1) got broken 16 months ago to make this
> a valid URL.

Can you please tell me how the distfile survey reacts on a double
/ in that path-part:

    ftp://ftp.csd.uch.gr//pub/X11/games/

Because either fetch or the ftpd doesn't correctly interpret the
%2f part:

  CWD /%2fpub/X11/games..                                                    
  550 /%2fpub/X11/games: No such file or directory...                        

If the distfile survey program correctly uses the // part, then
the problem is solved.

Edwin

-- 
Edwin Groothuis   |              Personal website: http://www.MavEtJu.org
edwin@mavetju.org |           Interested in MUDs? Visit Fatal Dimensions:
------------------+                       http://www.FatalDimensions.org/
Comment 4 Bill Fenner 2001-12-18 21:35:07 UTC
>Can you please tell me how the distfile survey reacts on a double
>/ in that path-part:
>
>    ftp://ftp.csd.uch.gr//pub/X11/games/

It ignores it; RFC 1738 says that the right thing to do in that
case is send the FTP command "CWD " but all FTP servers I've
experienced consider that a syntax error.

>Because either fetch or the ftpd doesn't correctly interpret the
>%2f part:

It's fetch, and it's a bug (see PR bin/32619).

  Bill