Bug 36351 - news/slrn: adding localization + dependencies
Summary: news/slrn: adding localization + dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pete Fritchman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-03-27 00:30 UTC by Thierry Thomas
Modified: 2002-04-19 02:08 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (2.45 KB, patch)
2002-03-27 00:30 UTC, Thierry Thomas 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas 2002-03-27 00:30:02 UTC 
	The port does not detect neither libintl nor libiconv at configure,
	and it does not install the .mo files.

Fix: Apply the following patch:

How-To-Repeat: 	- make configure and look at config.log;
	- make install and run with LC_ALL set within (da, de, fr, es, ...)
	  => slrn is still in english.
Comment 1 Patrick Li freebsd_committer freebsd_triage 2002-03-27 01:24:06 UTC 
Responsible Changed
From-To: freebsd-ports->petef

Over to maintainer
Comment 2 Thierry Thomas 2002-03-27 06:40:38 UTC 
Le 27 Mar 02 à  1:28:01 +0000, Thierry Thomas écrivait :
> 
> +@dirrm share/locale/pl/LC_MESSAGES
> +@dirrm share/locale/ru/LC_MESSAGES

Sorry, there was a mistake in my patch of pkg-plist: deinstalling the
port is not supposed to remove $LOCALBASE/share/locale/xx/LC_MESSAGES.

The real patch must be:


diff -urN /usr/ports/news/slrn.orig/Makefile /usr/ports/news/slrn/Makefile
--- /usr/ports/news/slrn.orig/Makefile	Tue Mar 26 22:13:49 2002
+++ /usr/ports/news/slrn/Makefile	Wed Mar 27 07:35:50 2002
@@ -19,13 +19,17 @@
 
 MAINTAINER=	petef@FreeBSD.org
 
-LIB_DEPENDS=	slang.1:${PORTSDIR}/devel/libslang
+LIB_DEPENDS=	slang.1:${PORTSDIR}/devel/libslang	\
+		intl.1:${PORTSDIR}/devel/gettext	\
+		iconv.3:${PORTSDIR}/converters/libiconv
 
 USE_BZIP2=	yes
 USE_GMAKE=	yes
 
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS=	--enable-ipv6 --disable-inews --with-slrnpull
+CONFIGURE_ARGS=	--enable-ipv6 --disable-inews --with-slrnpull	\
+		--with-libiconv-prefix=${LOCALBASE}
+CONFIGURE_ENV=	CFLAGS="${CFLAGS} -I${LOCALBASE}/include -L${LOCALBASE}/lib"
 
 .if !defined(WITHOUT_SSL)
 USE_OPENSSL=	YES
@@ -46,6 +50,7 @@
 	@${MKDIR} ${PREFIX}/share/examples/slrn
 	${INSTALL_DATA} ${WRKSRC}/doc/slrn.rc ${PREFIX}/share/examples/slrn
 	@${MKDIR} ${PREFIX}/share/examples/slrn/slrnpull
+	(cd ${WRKSRC}/po; ${SETENV} ${MAKE_ENV} ${MAKE} ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} install)
 .for file in FAQ README SETUP score slrn.rc slrnpull.conf slrnpull.sh
 	${INSTALL_DATA} ${WRKSRC}/doc/slrnpull/${file} ${PREFIX}/share/examples/slrn/slrnpull
 .endfor
diff -urN /usr/ports/news/slrn.orig/pkg-plist /usr/ports/news/slrn/pkg-plist
--- /usr/ports/news/slrn.orig/pkg-plist	Sun Nov 25 21:46:35 2001
+++ /usr/ports/news/slrn/pkg-plist	Wed Mar 27 07:35:10 2002
@@ -8,6 +8,15 @@
 share/examples/slrn/slrnpull/slrn.rc
 share/examples/slrn/slrnpull/slrnpull.conf
 share/examples/slrn/slrnpull/slrnpull.sh
+share/locale/da/LC_MESSAGES/slrn.mo
+share/locale/de/LC_MESSAGES/slrn.mo
+share/locale/es/LC_MESSAGES/slrn.mo
+share/locale/fr/LC_MESSAGES/slrn.mo
+share/locale/it/LC_MESSAGES/slrn.mo
+share/locale/ko/LC_MESSAGES/slrn.mo
+share/locale/nl/LC_MESSAGES/slrn.mo
+share/locale/pl/LC_MESSAGES/slrn.mo
+share/locale/ru/LC_MESSAGES/slrn.mo
 %%PORTDOCS%%share/doc/slrn/FAQ
 %%PORTDOCS%%share/doc/slrn/README.GroupLens
 %%PORTDOCS%%share/doc/slrn/README.SSL



-- 
Th. Thomas.
Comment 3 Pete Fritchman freebsd_committer freebsd_triage 2002-04-19 02:08:17 UTC 
State Changed
From-To: open->closed

Committed, thanks!  Sorry for the delay.