Bug 38320 - x11/xbindkeys doesn't install xbindkeys_show
Summary: x11/xbindkeys doesn't install xbindkeys_show
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-05-20 07:10 UTC by parv
Modified: 2002-05-23 02:04 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description parv 2002-05-20 07:10:02 UTC
x11/xbindkeys doesn't install xbindkeys_show when "WITH_GUI" has
been specified...

===>  Installing for xbindkeys-1.5.4
===>   xbindkeys-1.5.4 depends on executable: wish - found
===>   xbindkeys-1.5.4 depends on shared library: X11.6 - found
/bin/sh ./mkinstalldirs /usr/local/bin
  install -C -c -s -o root -g wheel -m 555  xbindkeys /usr/local/bin/xbindkeys
===>   Generating temporary packing list
install -C -c -o root -g wheel -m 444 /source/ports/x11/xbindkeys/work/xbindkeys-1.5.4/xbindkeysrc /usr/local/share/examples/xbindke
ys
install -C -c -o root -g wheel -m 444 /source/ports/x11/xbindkeys/work/xbindkeys-1.5.4/xbindkeys.1 /usr/local/man/man1
install -C -c -o root -g wheel -m 444 /source/ports/x11/xbindkeys/work/xbindkeys-1.5.4/xbindkeys_show.1 /usr/local/man/man1
===>   Registering installation for xbindkeys-1.5.4

...note the missing command "xbindkeys_show", but xbindkeys_show.1
man page was installed and the command is listed in the
package list.

How-To-Repeat: 
cd $PORTSDIR/x11/xbindkeys && make install -DWITH_GUI
Comment 1 obraun 2002-05-20 12:26:21 UTC
Thanks for the report.

A workaround is "make WITH_GUI=YES install".

The following patch fixes the problem.

Committer: Please commit this with the update in PR ports/38239.

Regards,
         Olli

diff -ruN xbindkeys.old/Makefile xbindkeys/Makefile
--- xbindkeys.old/Makefile	Mon May 20 09:30:09 2002
+++ xbindkeys/Makefile	Mon May 20 10:13:31 2002
@@ -18,6 +18,7 @@
 .if defined(WITH_GUI)
 RUN_DEPENDS=	wish:${PORTSDIR}/x11-toolkits/tk83
 PLIST_SUB+=	WITH_GUI=""
+SCRIPTS_ENV+=	WITH_GUI="YES"
 .else
 PLIST_SUB+=	WITH_GUI="@comment "
 .endif
Comment 2 Patrick Li freebsd_committer freebsd_triage 2002-05-23 02:04:01 UTC
State Changed
From-To: open->closed

Committed, Thanks!