Bug 40057 - send-pr -a flag does not work with -f
Summary: send-pr -a flag does not work with -f
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: gnu (show other bugs)
Version: 4.6-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bugmeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-07-01 02:30 UTC by dpelleg+bsd
Modified: 2014-11-22 17:46 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dpelleg+bsd 2002-07-01 02:30:04 UTC 
     If both the -f and -a flags are specified to send-pr, then
the -a file is not attached to the "FIX" section of whatever is in -f.
Instead, it is silently ignored.

Fix: 

I'm not sure if it's not a documentation problem. In any case, the
man page should warn about this, and so should the executable.
How-To-Repeat:  send-pr -f template -a file
Comment 1 Doug Barton freebsd_committer freebsd_triage 2002-07-01 02:53:45 UTC 
Responsible Changed
From-To: freebsd-bugs->bugbusters


To me, the man page is clear that -a should be a complete PR file, but 
SYNOPSIS should probably indicate that the two are mutually exclusive.
Comment 2 Ceri Davies freebsd_committer freebsd_triage 2003-08-11 20:32:36 UTC 
State Changed
From-To: open->patched

I committed a diff to -HEAD to make the two options work together. 
Keep this open as my MFC reminder.
Comment 3 Ceri Davies freebsd_committer freebsd_triage 2003-08-11 20:32:36 UTC 
Responsible Changed
From-To: bugbusters->ceri

I made the commit to -HEAD.
Comment 4 Ceri Davies freebsd_committer freebsd_triage 2003-11-12 20:35:11 UTC 
Responsible Changed
From-To: ceri->bugmeister

Assign to the bugmeister role. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40057 

Manually adding to audit trail by linimon on 20080125:
 
 It appears that the commit was backed out:
 
 http://www.freebsd.org/cgi/cvsweb.cgi/src/gnu/usr.bin/send-pr/send-pr.sh.diff?r1=1.31;r2=1.32
Comment 5 Gavin Atkinson freebsd_committer freebsd_triage 2008-03-06 11:35:05 UTC 
State Changed
From-To: patched->open

Patch was backed out
Comment 6 Marcus von Appen freebsd_committer freebsd_triage 2014-11-22 17:46:36 UTC 
Closing this, since send-pr has become obsolete for now.